Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18115 Login detection - proposed solution #1 #726

Closed
wants to merge 1 commit into from

Conversation

severinbeauvais
Copy link
Collaborator

@severinbeauvais severinbeauvais commented Oct 6, 2023

Do not delete this PR. See ticket for more details.

Issue #: bcgov/entity#18115

Description of changes:

  • added isAuthenticated as state property
  • set isAuthenticated when Keycloak roles are loaded (call by App.vue and Signin.vue)
  • added setIsAuthenticated action
  • updated isAuthenticated getter
  • added mutateIsAuthenticated mutation
  • initialized isAuthenticated state

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

- set isAuthenticated when Keycloak roles are loaded (call by App.vue and Signin.vue)
- added setIsAuthenticated action
- updated isAuthenticated getter
- added mutateIsAuthenticated mutation
- initialized isAuthenticated state
@severinbeauvais
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://namerequest-dev--pr-726-6p0j8vkt.web.app

@severinbeauvais severinbeauvais changed the title 18115 Proposed solution #1 18115 Login detection - proposed solution #1 Oct 6, 2023
@severinbeauvais
Copy link
Collaborator Author

This is not the chosen solution. See #742 instead.

Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants