Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Key value in BCOL refund email #9431

Closed
13 tasks
mstanton1 opened this issue Oct 7, 2021 · 6 comments
Closed
13 tasks

Add Key value in BCOL refund email #9431

mstanton1 opened this issue Oct 7, 2021 · 6 comments
Assignees
Labels
Client/Staff Feedback Dev Tasks for developers Pay Work for Pay Team payment STORY

Comments

@mstanton1
Copy link
Collaborator

mstanton1 commented Oct 7, 2021

Description

BCOL Help/Registries home team BA's have requested addition of the 'Key' field into the BCOL refund request emails that are triggered when the refunds are requested though the refund endpoint for BCOL clients using the new app.

The key field in the BCOL system is the invoice_number in pay.
E.g. of format is REG00071811

Existing BCOL Refund email format (sample):
Subject: BC Registries and Online Services Refunds for 2021-10-06

Body: 203377, 2021-10-06 10:04:37, Name Request fee, NR 8516360, 131.5

Updated BCOL Refund email format:
Subject: BC Registries and Online Services Refunds for 2021-10-06

Body: 203377, 2021-10-06 10:04:37, Name Request fee, NR 8516360, 131.5, REG00071811

Ops Process

  • Add Entity or Relationships label to zenhub ticket
  • Add Ops label
  • Add Priority1 label to zenhub ticket, if:
    • If the business says it is a priority
    • BA can use their business knowledge and best judgement if it is a priority or not
    • How long the ticket has been open
    • If we are still unsure, reach out to other BAs in the guild
  • Add ticket to "Ops" column
  • When ticket has been created, post the ticket in RocketChat '#Operations Tasks' channel
  • Reply All to IT Ops email (CC BA Inbox) and provide zenhub ticket number opened
  • Dev/BAs to resolve issue
  • DEV: Enter the time you worked on the ticket in the estimate
  • DEV: Tell BA it is ready to review
  • BAs review
  • Add ticket to the current milestone of the code base the ops ticket was relating to (i.e., if it's a Name Request issue, assign to current entities milestone, etc.)
  • Close Zenhub ticket
  • Tell IT Ops to close the ServiceNow Incident
@rarya-freshworks
Copy link

Scenario:

  • BCOL Payment and do refund (EB: Additional Item/Line from above should be in refund email)
  • Payment by other methods (EB: Additional Item/Line from above should not be in refund email)

@jyoti3286 jyoti3286 added this to the Relationships 11.3 milestone Oct 26, 2021
@jyoti3286 jyoti3286 added the Dev Tasks for developers label Oct 26, 2021
@SateeshFW SateeshFW removed this from the Relationships 11.4 milestone Nov 17, 2021
@JohnamLane
Copy link
Collaborator

@MatthewCai2002 Possible next ticket, but let's discuss first.

@seeker25
Copy link
Collaborator

seeker25 commented Oct 21, 2022

@MatthewCai2002
REG00071811 comes from the invoice_reference table, invoice can join via invoice.id to invoice_reference.invoice_id

@seeker25
Copy link
Collaborator

seeker25 commented Oct 28, 2022

Reviewed, merged and moved to staging, if there are more PR's to go.. we can move it back.

@seeker25
Copy link
Collaborator

seeker25 commented Nov 4, 2022

@AshnaMehta This will be a bit difficult to QA, we had to override the BCOL admin's email on TEST to send the email to Matthew.

@seeker25
Copy link
Collaborator

seeker25 commented Nov 4, 2022

we used

python q_cli.py -p '{"specversion": "1.x-wip", "type": "bc.registry.payment.drawdown.refundRequest", "source": "https://api.pay.bcregistry.gov.bc.ca/v1/invoices/23525", "id": 23525, "datacontenttype": "application/json", "data": {"identifier": "NR 5485102", "orderNumber": "REGT00023525", "transactionDateTime": "2022-11-02 10:46:44", "transactionAmount": 31.5, "transactionId": "REGT00023525", "refundDate": "20221102", "filingDescription": "Name Request fee", "bcolAccount": "115764", "bcolUser": "PA52417", "logo_url": "https://minio-test.apps.silver.devops.gov.bc.ca/public/bc_logo_for_email.png"}}'

and had to override
image.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client/Staff Feedback Dev Tasks for developers Pay Work for Pay Team payment STORY
Projects
None yet
Development

No branches or pull requests

7 participants