Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9431 - Added key to BCOL refund emails #1004

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

MatthewCai2002
Copy link
Contributor

Issue #: 9431
bcgov/entity#9431

Description of changes:
- added invoice_number as key to filingDescription in refund_data
- might need to change bcol_refund_email-template in account-mailer too

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #1004 (3254798) into main (bca253f) will increase coverage by 1.85%.
The diff coverage is 95.40%.

@@            Coverage Diff             @@
##             main    #1004      +/-   ##
==========================================
+ Coverage   91.04%   92.89%   +1.85%     
==========================================
  Files         165      126      -39     
  Lines        9576     8193    -1383     
==========================================
- Hits         8718     7611    -1107     
+ Misses        858      582     -276     
Flag Coverage Δ
bcolapi ?
eventlistenerqueue ?
payapi 92.89% <95.40%> (+0.16%) ⬆️
paymentjobs ?
reportapi ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pay-api/src/pay_api/models/invoice_reference.py 100.00% <ø> (ø)
pay-api/src/pay_api/models/routing_slip.py 95.96% <0.00%> (-0.91%) ⬇️
pay-api/src/pay_api/services/paybc_service.py 80.00% <ø> (ø)
pay-api/src/pay_api/services/fas/routing_slip.py 75.79% <75.00%> (+0.10%) ⬆️
pay-api/src/pay_api/services/flags.py 89.28% <89.28%> (ø)
pay-api/src/pay_api/__init__.py 89.47% <100.00%> (+0.58%) ⬆️
pay-api/src/pay_api/config.py 99.34% <100.00%> (+0.02%) ⬆️
pay-api/src/pay_api/exceptions/__init__.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/__init__.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/account_fee.py 100.00% <100.00%> (ø)
... and 79 more

@seeker25 seeker25 changed the title added key to BCOL refund emails 9431 - Added key to BCOL refund emails Oct 28, 2022
@seeker25 seeker25 added the enhancement New feature or request label Oct 28, 2022
@seeker25 seeker25 merged commit b96221a into bcgov:main Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants