Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GWELLS-2011/2013] HOTFIX** correct date_of_action to date_of_uploads #2037

Merged
merged 1 commit into from
Nov 9, 2023
Merged

[GWELLS-2011/2013] HOTFIX** correct date_of_action to date_of_uploads #2037

merged 1 commit into from
Nov 9, 2023

Conversation

LocalNewsTV
Copy link
Contributor

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [GWELLS-###]
  • Documentation is updated to reflect change

Description

This PR includes the following proposed change(s):

  • one date_of_action was leftover causing 1969 date to display in place of "Date Unknown"
  • renamed function to reflect being about date of uploads and not date of action

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@LocalNewsTV LocalNewsTV merged commit f68d110 into release Nov 9, 2023
10 checks passed
@LocalNewsTV LocalNewsTV deleted the gwells-2013-fix-date-display branch November 9, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidclaveau davidclaveau davidclaveau approved these changes

Assignees
No one assigned
Labels
Backend Frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LocalNewsTV @davidclaveau @bcgov-csnr-cd