Gwells-2211 *FEATURE add closed/abandoned wells colour #2264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
Revert change between main and search page well outline based on discussion with other devs
acatchpole
reviewed
Jul 8, 2024
| ['to-boolean', ['get', 'artesian']], '#1099FE', | ||
| '#0162FE' | ||
| ], | ||
| 'circle-radius': 3, | ||
| 'circle-stroke-color': [ | ||
| 'case', | ||
| ['==', ['get', 'well_status'], 'CLOSURE'], 'transparent', | ||
| ['==', ['get', 'well_status'], 'ABANDONED'], 'transparent', | ||
| ['to-boolean', ['get', 'artesian']], '#EE14CA', |
There was a problem hiding this comment.
When you're presenting the changes to the SO, make sure you highlight everything listed in the PR (sometimes the comments don't get read) and specifically this one. Given my understanding of how artesian conditions are used, they might want wells that have them to still be highlighted even when closed. I'm not saying undo the change right now, but double check with the SO.
There was a problem hiding this comment.
Ack, I will do that now, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Standards
HOTFIX,FEATURE,etc][GWELLS-###]README,functions,team documents]This PR includes the following proposed change(s):
Added case to make wells that have well_status as closure or abandoned a deep purple colour.
Added case to make wells that have well_status as closure or abandoned have a transparent outline and not take on the artesian fushcia outline.
Added a pulsing dot image in deep purple with lighter pulse colour to match pulsing artesian and pulsing well images.
Added to legend as decommissioned wells with deep purple dot.
Noticed that dot outline 'circle stroke color' was transparent default on load but black on search, corrected both to black outline.*reverted this change after discussion with devsThese shows the current discrepancy between well outlines (transparent vs black) on the main page vs search page