HCAP-1306 fix: react-error-overlay fix, enable auto refresh #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arranfw
changed the title
arranfw
force-pushed
the
fix/hot-reload
branch
from
d299b8f to
f469764
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
taraepp
approved these changes
Aug 23, 2022
arranfw
changed the title
rhattie-ey
added a commit
that referenced
this pull request
Jan 28, 2023
This package was added to the preinstall process to fix bug HCAP-1306. (See #809.) However, its presence caused package-lock generation to be non-deterministic, causing a new lock file every run. With the current dependencies, `react-error-overlay` will not go under 6.0.9 anyways, so no regression should occur.
rhattie-ey
added a commit
that referenced
this pull request
Feb 3, 2023
#868) * Updated some vulnerable client packages Updated all packages without breaking update in /client. Also updated the project-wide `moment` version. * Updated some vulnerable server packages Ran `npm audit fix` on /server. * Updated vulnerable server dependencies Updated: * `body-parser` from 1.19 to 1.20 * `express` from 4.17 to 4.18 * `nodemon` from 2.0.4 to 2.0.20 * Updated client `package-lock` * Removed `npm-force-resolutions` from client This package was added to the preinstall process to fix bug HCAP-1306. (See #809.) However, its presence caused package-lock generation to be non-deterministic, causing a new lock file every run. With the current dependencies, `react-error-overlay` will not go under 6.0.9 anyways, so no regression should occur.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the app becoming unresponsive after updating files and also triggers a browser refresh which should save us some effort
Stopgap until we upgrade packages across the board and get live-reload
The preinstall script forces the error overlay resolution but it causes a major package-lock diff ><
https://freshworks.atlassian.net/browse/HCAP-1306
Resources: