This repository has been archived by the owner on Jul 12, 2024. It is now read-only.
added sleep env variable for db connect timeout #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WadeBarnes
suggested changes
Mar 14, 2022
There was a problem hiding this comment.
We don't want to impose a fix length wait before attempting to connect, we want to configurably extent the serverSelectionTimeoutMS so the connection will only wait longer if it cannot connect to the database right away.
I believe it would just be an option parameter like useNewUrlParser and useUnifiedTopology; see MongoClient.connect here, https://mongodb.github.io/node-mongodb-native/3.7/api/MongoClient.html
WadeBarnes
suggested changes
Mar 14, 2022
Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
WadeBarnes
approved these changes
Mar 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality to wait 30 seconds (by default) to allow the db container to properly startup in openshift.
Set the amount of wait time using the environment variable
DB_CONNECT_SLEEPResolves: #348
Signed-off-by: wadeking98 wkingnumber2@gmail.com