This repository has been archived by the owner on Jul 12, 2024. It is now read-only.
Feature blank fields #364
Merged
Feature blank fields #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
esune
suggested changes
Apr 20, 2022
Comment on lines
39
to
48
| getSchemaAttrsByID(schema_name: string, schema_version: string): string[] { | ||
| const schemas = loadJSON("schemas.json") as SchemaDefinition[] | ||
| const filtered = schemas.filter((s) => s.schema_name === schema_name && s.schema_version === schema_version) | ||
| let schemaAttributes: string[] = [] | ||
| if (filtered.length > 0 && filtered[0].attributes) { | ||
| schemaAttributes = filtered[0].attributes | ||
| } | ||
| return schemaAttributes | ||
| } | ||
|
|
There was a problem hiding this comment.
This would likely be better located in utils/credential-exchange.ts as it is a utility method that might be reused elsewhere.
There was a problem hiding this comment.
change completed
Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
esune
approved these changes
Apr 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the user to leave unrequired fields blank.
Previously any blank field would be left out of the credential request and so aries would throw an error because the credential request wouldn't match the schema.
Resolves: #267