Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Keycloak Error In Cucumber Tests #2510

Merged
merged 13 commits into from
Mar 17, 2022
Merged

Fix Keycloak Error In Cucumber Tests #2510

merged 13 commits into from
Mar 17, 2022

Conversation

TayGov
Copy link
Contributor

@TayGov TayGov commented Mar 14, 2022 •
edited
Loading

Description

This PR includes the following proposed change(s):

Fix the cucumber tests

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring / Documentation
  • Version change

if your change is a breaking change, please add breaking change label to this PR

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Does the change impact or break the Docker build?

  • Yes
  • No

If Yes: Has Docker been updated accordingly?

  • Yes
  • No

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

@TayGov TayGov marked this pull request as draft March 16, 2022 14:55
@TayGov TayGov changed the title Try building Fix Keycloak Error In Cucumber Tests Mar 17, 2022
@TayGov TayGov requested review from gpoleze and BrendanBeach March 17, 2022 16:38
@TayGov TayGov self-assigned this Mar 17, 2022
@TayGov TayGov marked this pull request as ready for review March 17, 2022 16:40
BrendanBeach
BrendanBeach approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@BrendanBeach BrendanBeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, great work!

@TayGov TayGov merged commit 25bc808 into master Mar 17, 2022
@TayGov TayGov deleted the test/cucumber-fix branch March 17, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrendanBeach BrendanBeach BrendanBeach approved these changes

@gpoleze gpoleze Awaiting requested review from gpoleze

Assignees

@TayGov TayGov

Labels
(⌐■_■)ノ＼(■_■ ) 🦡 BADGER 🚴 cash bug Something isn't working 🚗 🐱 🐈 😹 😸 😼 🥒 cucumber dependencies docker everything is awesome EXTREME DEVOPS 🍴 fork Git Action GOTTA GO FAST hello there HUGE Humongous big It's Working! jedi ⭐ keycloak Label name label LARGE Large PR many tries MONOLITHIC More Labels! MORE THAN MEETS THE EYE 🤖 Mustard 🥄 When Mustard is needed over1000 pipeline 🍕 🏷️ porkchop sandwiches 🏎️ READY FOR REVIEW stellar TEAMWORK! (⌐■_■) that's a lot of code tiny small small change UNDERWHELMING up for discussion version 🖖 QUARK ⌚ sync ⌚ yuge 🥉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TayGov @BrendanBeach