Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18026 Add allowable actions for AGM location change #2229

Merged
merged 7 commits into from
Oct 13, 2023

Conversation

leodube-aot
Copy link
Collaborator

@leodube-aot leodube-aot commented Oct 11, 2023

Issue #: /bcgov/entity#18026

Description of changes:

  • Added Allowable Change item for filing type = agmLocationChange
  • Applicable only to company types - BC Ltd., BEN, ULC, CCC
  • Filing is not allowed when one or more of following is true for business
    • Business is in "Not in Good Standing" state
    • Business is frozen
    • Business has a pending or draft filing
  • Created Unit Tests

Note: The unit tests are currently blocked by tickets in progress.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

legal-api/requirements.txt Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
30.5% 30.5% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #2229 (8692b78) into main (d024a87) will increase coverage by 0.06%.
Report is 22 commits behind head on main.
The diff coverage is 91.83%.

@@            Coverage Diff             @@
##             main    #2229      +/-   ##
==========================================
+ Coverage   76.97%   77.03%   +0.06%     
==========================================
  Files         160      161       +1     
  Lines        9793     9838      +45     
  Branches     1654     1660       +6     
==========================================
+ Hits         7538     7579      +41     
- Misses       1797     1801       +4     
  Partials      458      458              
Flag Coverage Δ
legalapi 77.03% <91.83%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
legal-api/src/legal_api/core/filing.py 86.50% <100.00%> (+0.04%) ⬆️
legal-api/src/legal_api/core/meta/filing.py 90.55% <100.00%> (ø)
legal-api/src/legal_api/models/filing.py 92.41% <ø> (ø)
legal-api/src/legal_api/services/authz.py 94.54% <ø> (ø)
legal-api/src/legal_api/services/utils.py 100.00% <100.00%> (ø)
...ervices/warnings/business/business_checks/firms.py 97.45% <100.00%> (ø)
legal-api/src/legal_api/version.py 100.00% <100.00%> (ø)
...gal_api/services/filings/validations/validation.py 76.85% <66.66%> (+0.58%) ⬆️
...ervices/filings/validations/agm_location_change.py 91.66% <91.66%> (ø)

... and 2 files with indirect coverage changes

@argush3 argush3 merged commit ddcdf62 into bcgov:main Oct 13, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants