feat: digital credential queuing service #2299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
* feat: devcontainer configuraton for vscode Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: hard code digital business card schema Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: hard code digital business card schema Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: issue credentials through Traction tenant Signed-off-by: Akiff Manji <amanji@petridish.dev> * refactor: app initialization workflow Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: use out-of-band invitation for connecting Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: use v2.0 for issuing credential Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: web socket implmentation with flask-socketio Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: db migration script to enable revocation Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: revocation endpoint Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: replace endpoints Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: fix linting errors Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: update requirements Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: update tests Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: traction token exchanger Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: update workflow variables Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: update workflow variables Signed-off-by: Akiff Manji <amanji@petridish.dev> * refactor: ws cors setting is a config option Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: fix linting errors Signed-off-by: Akiff Manji <amanji@petridish.dev> * refactor: clean up init in digital credential service Signed-off-by: Akiff Manji <amanji@petridish.dev> --------- Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
…nto feature-digital-credentials
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
* feat: devcontainer configuraton for vscode Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: hard code digital business card schema Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: hard code digital business card schema Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: issue credentials through Traction tenant Signed-off-by: Akiff Manji <amanji@petridish.dev> * refactor: app initialization workflow Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: use out-of-band invitation for connecting Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: use v2.0 for issuing credential Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: web socket implmentation with flask-socketio Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: db migration script to enable revocation Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: revocation endpoint Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: replace endpoints Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: fix linting errors Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: update requirements Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: update tests Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: traction token exchanger Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: update workflow variables Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: update workflow variables Signed-off-by: Akiff Manji <amanji@petridish.dev> * refactor: ws cors setting is a config option Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: fix linting errors Signed-off-by: Akiff Manji <amanji@petridish.dev> * refactor: clean up init in digital credential service Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: endpoints to reset credential offers Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: credential id lookup table Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: add business roles Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: fix tests and linting Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: fix tests Signed-off-by: Akiff Manji <amanji@petridish.dev> --------- Signed-off-by: Akiff Manji <amanji@petridish.dev>
…nto feature-digital-credentials
Signed-off-by: Akiff Manji <amanji@petridish.dev>
|
Sonarcloud reports this warning. Can I tell SC to ignore it?
|
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
|
Going to split out the Legal API changes into a separate PR. Those contain the fix for bcgov/entity#18474 but will be held up until this is approved. |
Do you want a separate ticket to track Legal API changes? It mostly matters for tracking features/bugs through our pipelines (eg, to let our QA guy know what is available to test). |
argush3
reviewed
Nov 17, 2023
queue_services/entity-digital-credentials/src/entity_digital_credentials/config.py
Outdated
Show resolved
Hide resolved
argush3
reviewed
Nov 17, 2023
queue_services/entity-digital-credentials/src/entity_digital_credentials/config.py
Outdated
Show resolved
Hide resolved
argush3
reviewed
Nov 17, 2023
queue_services/entity-digital-credentials/src/entity_digital_credentials/config.py
Outdated
Show resolved
Hide resolved
argush3
reviewed
Nov 18, 2023
queue_services/entity-digital-credentials/src/entity_digital_credentials/config.py
Outdated
Show resolved
Hide resolved
argush3
reviewed
Nov 18, 2023
queue_services/entity-digital-credentials/src/entity_digital_credentials/config.py
Outdated
Show resolved
Hide resolved
argush3
reviewed
Nov 18, 2023
queue_services/entity-digital-credentials/src/entity_digital_credentials/config.py
Outdated
Show resolved
Hide resolved
I think it should be safe to ignore this |
I linked a separate ticket to that PR |
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Done. |
argush3
reviewed
Nov 20, 2023
queue_services/entity-digital-credentials/src/entity_digital_credentials/config.py
Outdated
Show resolved
Hide resolved
argush3
reviewed
Nov 20, 2023
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
|
My comment about dc.yaml might not have been that clear. We actually need the dc.yaml file. Can you copy it over from entity-bn? And from a quick glance it looks like there is only line to update. |
Signed-off-by: Akiff Manji <amanji@petridish.dev>
Signed-off-by: Akiff Manji <amanji@petridish.dev>
|
SonarCloud Quality Gate failed.
|
argush3
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Looks good!
As per our discussion, outstanding comments & code smells will be addressed in future PRs.
I will add in the vault.json file once this PR has been merged.
We will also need to address linting errors, adding unit tests and updates to get CI/CD working properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: bcgov/entity#18521
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).