-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
18490 Add displayLedger flag #2351
18490 Add displayLedger flag #2351
Conversation
|
Kevin, there are no changed files atm. |
Yeah, I think we don't need to changes the legal-API for this |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2351 +/- ##
==========================================
- Coverage 77.37% 76.66% -0.72%
==========================================
Files 202 168 -34
Lines 11602 10516 -1086
Branches 1961 1785 -176
==========================================
- Hits 8977 8062 -915
+ Misses 2043 1969 -74
+ Partials 582 485 -97
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a test that the value is True for all filings except Admin Freeze?
Yes, I checked |
Great. How about a unit test? |
I updated the unit test too. The current 4 failed cases don't relate to my updates. |
I don't see a unit test that verifies that |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the extra unit test.
This looks good to me.
@kzdev420 can you change this pr to ready for review? |
Issue #: /bcgov/entity#18490
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).