23522-23562 continuation in workflow change #3026
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vysakh-menon-aot
changed the title
vysakh-menon-aot
requested review from
ketaki-deodhar,
argush3,
severinbeauvais and
chenhongjing
legal-api/src/legal_api/resources/v2/business/business_filings/business_filings.py
Outdated
Show resolved
Hide resolved
legal-api/src/legal_api/resources/v2/business/business_filings/business_filings.py
Show resolved
Hide resolved
legal-api/src/legal_api/resources/v2/business/business_filings/business_filings.py
Show resolved
Hide resolved
legal-api/src/legal_api/resources/v2/business/business_filings/business_filings.py
Show resolved
Hide resolved
legal-api/src/legal_api/resources/v2/business/business_filings/business_documents.py
Show resolved
Hide resolved
legal-api/src/legal_api/resources/v2/business/business_filings/business_filings.py
Show resolved
Hide resolved
ketaki-deodhar
approved these changes
Oct 11, 2024
| @@ -73,6 +73,7 @@ async def process_event(msg: Dict, flask_app: Flask): # pylint: disable=too-man | |||
| with flask_app.app_context(): | |||
| if msg['type'] == 'bc.registry.admin.bn': | |||
| await admin.process(msg) | |||
| return | |||
There was a problem hiding this comment.
What is this fixing? Please call it out in your PR description or ticket so it's recorded.
There was a problem hiding this comment.
This return was removed by mistake (adding it back now). It was not breaking any functionality but its adding unwanted logs in entity-bn.
| is_future_effective=True) | ||
| filing_name='unknownFiling', | ||
| filing_status='PAID', | ||
| is_future_effective=True) |
There was a problem hiding this comment.
Thanks for all the cleanup, in this file and the others.
| review.save() | ||
|
|
||
| filing.set_review_decision(Filing.Status.CHANGE_REQUESTED.value) | ||
| if filing_status != Filing.Status.DRAFT.value: |
There was a problem hiding this comment.
I always prefer checking the positive conditions, since a negative condition could cause errors if, say, we added a filing status. Up to you whether to change or leave this.
legal-api/tests/unit/services/filings/validations/test_continuation_in.py
Show resolved
Hide resolved
severinbeauvais
approved these changes
Oct 11, 2024
chenhongjing
approved these changes
Oct 11, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#23522, /bcgov/entity#23562
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).