Skip to content

Commit

Permalink
DESENG-496: Fixed Comments cannot be approved (#2398)
Browse files Browse the repository at this point in the history
Added missing transactional decorator
  • Loading branch information
ratheesh-aot authored Feb 28, 2024
1 parent 28fd55e commit d3440c1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.MD
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
## February 27, 2024
- **Bug Fix**Comments cannot be approved while reviewing [DESENG-496](https://apps.itsm.gov.bc.ca/jira/browse/DESENG-496)
- Fixed by adding a missing decorator for transactional methods.
- **Task**Enhance analytics api for Improved Readability and Maintainability [DESENG-492](https://apps.itsm.gov.bc.ca/jira/browse/DESENG-492)
- Refactor analytics-api config to harmonize its structure and conventions with met-api.
- Ensure the sample.env file maintains consistent formatting.
Expand Down
1 change: 1 addition & 0 deletions met-api/src/met_api/services/submission_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ def _validate_fields(submission):
raise ValueError('Engagement not open to submissions')

@classmethod
@transactional()
def review_comment(cls, submission_id, staff_review_details: dict, external_user_id) -> SubmissionSchema:
"""Review comment."""
user = StaffUserService.get_user_by_external_id(external_user_id)
Expand Down

0 comments on commit d3440c1

Please sign in to comment.