Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POST & GET integration for maps #1351

Merged
merged 5 commits into from
Mar 13, 2023
Merged

Conversation

djnunez-aot
Copy link
Collaborator

@djnunez-aot djnunez-aot commented Mar 10, 2023

Issue #1290 :
#1290

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@djnunez-aot djnunez-aot changed the title POST & GET intergration for maps POST & GET integration for maps Mar 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2023

Codecov Report

Merging #1351 (562433e) into main (14cce24) will decrease coverage by 0.17%.
The diff coverage is 26.47%.

@@            Coverage Diff             @@
##             main    #1351      +/-   ##
==========================================
- Coverage   71.93%   71.76%   -0.17%     
==========================================
  Files         315      315              
  Lines        9060     9085      +25     
  Branches      635      640       +5     
==========================================
+ Hits         6517     6520       +3     
- Misses       2436     2456      +20     
- Partials      107      109       +2     
Flag Coverage Δ
metapi 79.28% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
met-api/src/met_api/models/widget_map.py 64.00% <0.00%> (-2.67%) ⬇️
...eb/src/services/widgetService/MapService/index.tsx 29.41% <ø> (ø)
...gagement/form/EngagementWidgets/Map/MapContext.tsx 25.00% <21.05%> (-10.72%) ⬇️
...nts/engagement/form/EngagementWidgets/Map/Form.tsx 28.57% <22.22%> (-3.43%) ⬇️
met-api/src/met_api/resources/widget_map.py 61.36% <75.00%> (ø)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@saravanpa-aot saravanpa-aot merged commit cf86b38 into bcgov:main Mar 13, 2023
NatSquared pushed a commit that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants