Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add export cac form submissions option #2183

Merged
merged 11 commits into from
Sep 13, 2023

Conversation

jadmsaadaot
Copy link
Collaborator

Issue #: #2106

Description of changes:

  • Add export cac form submissions option in action drop down for superusers and assigned TMs

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@jadmsaadaot jadmsaadaot self-assigned this Sep 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2023

Codecov Report

Merging #2183 (33e1b58) into main (2b89a3d) will decrease coverage by 0.08%.
The diff coverage is 60.00%.

❗ Current head 33e1b58 differs from pull request most recent head 3d27c2c. Consider uploading reports for the commit 3d27c2c to get more accurate results

@@            Coverage Diff             @@
##             main    #2183      +/-   ##
==========================================
- Coverage   68.80%   68.73%   -0.08%     
==========================================
  Files         467      468       +1     
  Lines       15097    15174      +77     
  Branches     1180     1184       +4     
==========================================
+ Hits        10388    10430      +42     
- Misses       4508     4543      +35     
  Partials      201      201              
Flag Coverage Δ
metapi 77.25% <62.68%> (-0.17%) ⬇️
metweb 61.45% <53.57%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
met-web/src/apiManager/endpoints/index.ts 100.00% <ø> (ø)
...-web/src/components/common/FileUpload/Uploader.tsx 54.54% <ø> (+4.54%) ⬆️
...m/EngagementWidgets/Subscribe/FormSignUpDrawer.tsx 28.39% <ø> (+1.01%) ⬆️
met-web/src/services/userService/constants.ts 100.00% <ø> (ø)
met-web/src/services/FormCAC/index.tsx 45.45% <40.00%> (ø)
met-api/src/met_api/services/cac_form_service.py 45.71% <44.44%> (-1.35%) ⬇️
met-api/src/met_api/resources/cac_form.py 55.81% <52.63%> (-4.19%) ⬇️
.../components/engagement/listing/ActionsDropDown.tsx 59.77% <56.52%> (-2.92%) ⬇️
met-api/src/met_api/models/cac_form.py 94.44% <66.66%> (-5.56%) ⬇️
...rc/met_api/services/document_generation_service.py 80.55% <76.19%> (-5.66%) ⬇️
... and 3 more

@jadmsaadaot jadmsaadaot marked this pull request as ready for review September 13, 2023 17:52
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Comment on lines +59 to +60
EXPORT_ALL_CAC_FORM_TO_SHEET = 'export_all_cac_form_to_sheet' # Allows users to export CAC form to csv
EXPORT_CAC_FORM_TO_SHEET = 'export_cac_form_to_sheet' # Allows users to export CAC form to csv
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats the difference between this two?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To do this:
image

@jadmsaadaot jadmsaadaot merged commit 4d50737 into bcgov:main Sep 13, 2023
NatSquared pushed a commit that referenced this pull request Oct 19, 2023
* Add export cac form submissions

* update template name

* Fix lint issue

* update comment service to use the new document generation service method

* remove unnecessary checks

* remove unused import

* remove console logs

* remove problematic check

* Remove unused import

* Remove unused variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants