Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull projectId from query params and redirect to login #2203

Merged
merged 4 commits into from
Sep 15, 2023

Conversation

jadmsaadaot
Copy link
Collaborator

Issue #: #2184

Description of changes:

  • Pull project Id from query params to project metadata in engagement create
  • If loggedout redirect to login and redirect back when visiting engagement create

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@jadmsaadaot jadmsaadaot self-assigned this Sep 15, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jadmsaadaot jadmsaadaot marked this pull request as ready for review September 15, 2023 18:42
@codecov-commenter
Copy link

Codecov Report

Merging #2203 (b3d585f) into main (04523ec) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2203      +/-   ##
==========================================
+ Coverage   68.77%   68.78%   +0.01%     
==========================================
  Files         469      469              
  Lines       15224    15228       +4     
  Branches     1184     1186       +2     
==========================================
+ Hits        10470    10475       +5     
+ Misses       4554     4553       -1     
  Partials      200      200              
Flag Coverage Δ
metweb 61.45% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...b/src/components/engagement/form/ActionContext.tsx 50.00% <100.00%> (+1.87%) ⬆️
met-web/src/services/userService/index.ts 32.35% <100.00%> (ø)

@saravanpa-aot saravanpa-aot merged commit fb43469 into bcgov:main Sep 15, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants