Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make share thoughts button optional #2282

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

jadmsaadaot
Copy link
Collaborator

Issue #: #2281

Description of changes:

  • Remove the survey button from the banner section
  • Make the survey button an optional prop that optionally renders
  • Pass the survey button to the standalone banner but not the original met banner

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@jadmsaadaot jadmsaadaot self-assigned this Sep 27, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #2282 (faeccfb) into main (ec9349b) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2282      +/-   ##
==========================================
- Coverage   68.59%   68.57%   -0.02%     
==========================================
  Files         472      472              
  Lines       15572    15563       -9     
  Branches     1190     1187       -3     
==========================================
- Hits        10681    10672       -9     
  Misses       4685     4685              
  Partials      206      206              
Flag Coverage Δ
metweb 61.53% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...engagement/view/EngagementBanner/BannerSection.tsx 100.00% <100.00%> (ø)
...ponents/engagement/view/EngagementBanner/index.tsx 100.00% <100.00%> (ø)
.../src/components/engagement/view/EngagementView.tsx 76.92% <ø> (ø)

@jadmsaadaot jadmsaadaot marked this pull request as ready for review September 28, 2023 16:20
@jadmsaadaot jadmsaadaot merged commit 4870ef7 into bcgov:main Sep 28, 2023
9 checks passed
NatSquared pushed a commit that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants