Merge SSO changes into dev #2342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Overhaul of most configuration files * No longer using semver; update CHANGELOG.MD
* feature/deseng415: Added recording of date with feedback submission and displaying the data on admin side. * feature/deseng415: Fixed feedback schema, removed yup import, fixed change log date.
* bugfix/deseng429: Removed outdated service class. * bugfix/deseng429: Changed version and changelog to match deployments to gdx-main.
#2338) Co-authored-by: Alex <awintschel@gmail.com>
Co-authored-by: Alex <awintschel@gmail.com>
NatSquared
requested review from
jadmsaadaot,
djnunez-aot,
saravanpa-aot and
VineetBala-AOT
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
ShawnTurple
reviewed
Dec 11, 2023
| 'testing': TestConfig, | ||
| } | ||
| try: | ||
| print(f'Loading configuration: {environment}...') |
There was a problem hiding this comment.
is print the logging mechanism for this application, no logging plugin or code
I'm guessing you don't have access to the logger at this point.
There was a problem hiding this comment.
Print was the logging mechanism previously used in this file. I can upgrade to current_app.logger.debug :)
There was a problem hiding this comment.
Nevermind; I cannot. current_app is only defined after the configuration is set up, and that is done in this file. I'll write a ticket to look into uses of print() in the app and see if there are better alternatives
ShawnTurple
approved these changes
Dec 11, 2023
jareth-whitney
approved these changes
Dec 11, 2023
| @@ -99,7 +97,7 @@ def _get_scope_options(user_roles, has_team_access): | |||
| return EngagementScopeOptions(restricted=False) | |||
| if has_team_access: | |||
| # return those engagements where user has access for edit members.. | |||
| # either he has edit_member role or check if he is a team member | |||
| # either they have edit_member role or check if they are a team member | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: 🎟️DESENG-408
Description of changes:
Most of the configuration changes required to make MET function correctly when using the BC Government's hosted Single Sign On Keycloak servers.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).