DESENG-437: Resolved a timezone discrepancy while publishing #2349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the title and caption of the change log file as it is not relevant anymore
Baelx
requested changes
Jan 10, 2024
There was a problem hiding this comment.
Nice, quick fix. Thanks @ratheesh-aot ! Could you please just update the Changelog to correct the order of dates? Right now, we have two headings for January 9th and one of them is buried a little deeper.
Could you please move the latest date to the top and add harmonize all list items under the same date? Hope that's clear and let me know if you need further clarification.
|
@Baelx Updated the changelog as suggested. Please review |
Baelx
approved these changes
Jan 10, 2024
|
|
Fixing a runtime SQLALCHEMY_DATABASE_URI missing error. |
Baelx
approved these changes
Jan 10, 2024
NatSquared
pushed a commit
that referenced
this pull request
Jan 19, 2024
* DESENG-437: Fixing Publish engagement timezone and error message Removed the title and caption of the change log file as it is not relevant anymore * DESENG-437: Fixed CHANGELOG conflicts * Updating the changelog * Fixing SQLALCHEMY_DATABASE_URI error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-437
Description of changes:
Implemented a user-friendly message for scenarios where no engagements are scheduled for publication.
Resolved a timezone discrepancy in the engagement publication process.
Previously, the system compared the UTC-formatted scheduled dates in the database against the local timezone of the machine running the cron job. This discrepancy led to failures in identifying engagements scheduled for or before the current time. The comparison logic has now been modified to use the current time in UTC, ensuring accurate retrieval of scheduled engagements.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).