DESENG-484: Adding max age for cors #2377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Baelx
requested changes
Feb 8, 2024
| # This value is used to indicate how long the results of a preflight request (OPTIONS) can be cached | ||
| # by the client, reducing the frequency of preflight requests for the specified HTTP methods. | ||
| # Adjust this value based on security considerations. | ||
| CORS_MAX_AGE = os.getenv('CORS_MAX_AGE', None) # Default: 0 seconds |
There was a problem hiding this comment.
I like that you did this with an environment variable! A couple things:
- Could we make sure to set this in Openshift before we close the ticket? Looks like 2 hours is the maximum value for modern chromium browsers (Firefox is 72 hrs). Either this or we could set the default to be 2 hours.
- Our server is CORS-aware and checking for CORS origins so what are the security considerations here?
There was a problem hiding this comment.
Sure, I will set it in Openshift before closing the ticket.
For enhanced security considerations, configuring Access-Control-Max-Age as an environment variable provides the flexibility to adjust its duration or even eliminate it entirely in response to security concerns. Online recommendations suggest maintaining a shorter duration for Access-Control-Max-Age to mitigate potential risks.
Baelx
approved these changes
Feb 9, 2024
VineetBala-AOT
added a commit
that referenced
this pull request
Feb 12, 2024
* DESENG-484: Adding max age for cors (#2377)
NatSquared
pushed a commit
that referenced
this pull request
Feb 12, 2024
* DESENG-484: Adding max age for cors (#2377)
ratheesh-aot
pushed a commit
to ratheesh-aot/met-public
that referenced
this pull request
Feb 16, 2024
* DESENG-484: Adding max age for cors (bcgov#2377)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-484
Description of changes:
- Introduces a new configuration variable to specify the maximum age for Cross-Origin Resource Sharing (CORS)
- Modified the CORS preflight method to utilize this newly introduced variable.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).