[To Feature ] DESENG-511: Survey translation model #2406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NatSquared
approved these changes
Mar 6, 2024
| 'form_json' | ||
| ), # Returns `None` if 'form_json' is not in `data` as its optional | ||
| ) | ||
| db.session.add(survey_translation) |
There was a problem hiding this comment.
This can be survey_translation.save() instead, a method inherited from the BaseModel
There was a problem hiding this comment.
Thanks @NatSquared . Will follow that.
ratheesh-aot
merged commit 94a53bf
into
bcgov:DESENG-511-SurveyTranslation-Final
1 check passed
ratheesh-aot
added a commit
that referenced
this pull request
Mar 8, 2024
* DESENG-511: Survey translation model (#2406) * DESENG-511: Adding API for survey translation * DESENG-511 : Added Unit test Survey translation * DESENG-511: Fixed the review comment * DESENG-511: Fixing lint * Updaed Changelog * DESENG-511: Fixing Review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-511
Description of changes:
A survey translation model added
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).