Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TO MAIN] DESENG-510 - Engagement Translation model and API #2415

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

VineetBala-AOT
Copy link
Collaborator

Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-510

Description of changes:
Feature PR
[#2412 ] - Approved

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

Copy link

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 93.92713% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 74.90%. Comparing base (8366029) to head (7699442).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2415      +/-   ##
==========================================
+ Coverage   74.65%   74.90%   +0.25%     
==========================================
  Files         537      541       +4     
  Lines       18555    18802     +247     
  Branches     1349     1349              
==========================================
+ Hits        13852    14084     +232     
- Misses       4496     4511      +15     
  Partials      207      207              
Flag Coverage Δ
metapi 85.88% <93.92%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
met-api/src/met_api/models/__init__.py 100.00% <100.00%> (ø)
met-api/src/met_api/resources/__init__.py 100.00% <100.00%> (ø)
...-api/src/met_api/schemas/engagement_translation.py 100.00% <100.00%> (ø)
...pi/src/met_api/resources/engagement_translation.py 98.76% <98.76%> (ø)
...t-api/src/met_api/models/engagement_translation.py 96.49% <96.49%> (ø)
...met_api/services/engagement_translation_service.py 86.51% <86.51%> (ø)

@VineetBala-AOT VineetBala-AOT marked this pull request as ready for review March 11, 2024 23:16
Copy link
Collaborator

@Baelx Baelx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like everything was already approved from before. You're good to go

@VineetBala-AOT VineetBala-AOT merged commit c27ddcd into main Mar 13, 2024
11 checks passed
@VineetBala-AOT VineetBala-AOT deleted the feature/deseng-510-final branch March 13, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants