-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[To Main] Task - DESENG-676: Combine custom and summary content #2580
[To Main] Task - DESENG-676: Combine custom and summary content #2580
Conversation
* DESENG-675 Make widget component "reusable" * DESENG-675 Update changelog, contributing, met-web tests * DESENG-675 Merge import statements, add warning style to widget deletion
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2580 +/- ##
==========================================
- Coverage 76.03% 76.02% -0.02%
==========================================
Files 609 597 -12
Lines 22105 21652 -453
Branches 1797 1770 -27
==========================================
- Hits 16808 16460 -348
+ Misses 5033 4936 -97
+ Partials 264 256 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this! I'm always happy to see files being deleted in the code base :)
There may be a test debugging function that needs to be removed!
@staticmethod | ||
def _find_higest_sort_index(engagement_id): | ||
# find the highest sort order of the engagement content | ||
sort_index = 0 | ||
contents = EngagementContentModel.get_contents_by_engagement_id(engagement_id) | ||
contents = EngagementContentModel.find_by_engagement_id(engagement_id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the names less redundant here :)
@@ -5,16 +5,16 @@ import { ActionContext } from './ActionContext'; | |||
import { Skeleton } from '@mui/material'; | |||
import { getEditorStateFromRaw } from 'components/common/RichTextEditor/utils'; | |||
|
|||
export const EngagementContent = () => { | |||
const { richContent, isEngagementLoading } = useContext(ActionContext); | |||
export const EngagementContent = ({ index = 0 }: { index?: number }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the old view work with this. Hopefully we can ditch this code soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope so too 😆
@@ -187,7 +192,7 @@ describe('Engagement View page tests', () => { | |||
mockWidgetsRtkUnwrap.mockReturnValueOnce(Promise.resolve([whoIsListeningWidget])); | |||
mockContactRtkUnwrap.mockReturnValueOnce(Promise.resolve(mockContact)); | |||
const { container } = render(<RouterProvider router={router} />); | |||
|
|||
screen.debug(undefined, 10000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be here still?
Quality Gate passedIssues Measures |
Issue #: 🎟️ DESENG-676
Description of changes:
the existing EngagementContent table
User Guide update ticket (if applicable):