Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[To Main] Task - DESENG-682: Upgrade to node 20 #2583

Merged
merged 6 commits into from
Aug 28, 2024

Conversation

NatSquared
Copy link
Contributor

Issue #: 🎟️ DESENG-682

Description of changes:

  • Task Upgrade to Node v20
    • Upgraded deployment / CI configs to reference Node v20

User Guide update ticket (if applicable):

Copy link

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.03%. Comparing base (be4394d) to head (a60c957).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2583   +/-   ##
=======================================
  Coverage   76.03%   76.03%           
=======================================
  Files         609      609           
  Lines       22105    22105           
  Branches     1797     1797           
=======================================
  Hits        16808    16808           
  Misses       5033     5033           
  Partials      264      264           
Flag Coverage Δ
metweb 65.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@jareth-whitney jareth-whitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a very simple change to update our node CI version. Not much to comment on here. Merge at will.

@@ -31,7 +31,7 @@ jobs:

strategy:
matrix:
node-version: [16.x]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize we were still targeting 16 for our CI!

@NatSquared NatSquared merged commit b0cb3b1 into main Aug 28, 2024
8 checks passed
@NatSquared NatSquared deleted the task/DESENG-682-upgrade-to-node-20 branch August 28, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants