Fix/site business licence upload #2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hogmann
added
Bug
hogmann
requested review from
mtpultz,
neophyte57,
AMiKaH,
james-hollinger,
Paahn and
johnnyl6
mtpultz
approved these changes
Mar 25, 2022
hogmann
added a commit
that referenced
this pull request
Mar 25, 2022
* check documentGuid exists before comparing to current * api handle if a previous business licence has no document * overview validation for users who didn't have a licence uploaded * null coel Co-authored-by: Nathan <Hogman>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To re-create the bug
This can also be seen on first submission when you get to the overview page and go back to edit the business licence page.
The site will not have a document associated with the business licence.
Updated the overview and api to handle users coming back after having this bug affect them and need to add their business licence again.