Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRIME-2789 - Adjustments based on demo feedback #2592

Merged
merged 6 commits into from
Sep 19, 2024
Merged

PRIME-2789 - Adjustments based on demo feedback #2592

merged 6 commits into from
Sep 19, 2024

Conversation

neophyte57
Copy link
Collaborator

No description provided.

@neophyte57 neophyte57 added Backend Updates to the backend of the application Ready For Review PR is ready for code review labels Sep 19, 2024
@neophyte57 neophyte57 self-assigned this Sep 19, 2024
bergomi02
bergomi02 approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@bergomi02 bergomi02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, I think it needs to be tested in Test Environment.

@neophyte57 neophyte57 closed this Sep 19, 2024
@neophyte57 neophyte57 reopened this Sep 19, 2024
@bergomi02
Copy link
Collaborator

@neophyte57
I tested this PR locally. When I did that, I accidently commit something to the branch. No actual changes though, something internal GitHub things, I am not sure. That might cause the build issue here.

@neophyte57 neophyte57 merged commit 3b988c3 into develop Sep 19, 2024
13 checks passed
@neophyte57 neophyte57 deleted the feature/PRIME-2789-event-log-on-getgpiddetail branch September 19, 2024 22:58
@neophyte57
Copy link
Collaborator Author

@neophyte57 I tested this PR locally. When I did that, I accidently commit something to the branch. No actual changes though, something internal GitHub things, I am not sure. That might cause the build issue here.

Yeah weird problem ... I added to a comment (845c62d) to force another build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergomi02 bergomi02 bergomi02 approved these changes

Assignees

@neophyte57 neophyte57

Labels
Backend Updates to the backend of the application Ready For Review PR is ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neophyte57 @bergomi02