16634 Base changes for "way of navigating" story (new branch "release-5.0.0") #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Eve, Omid -- FYI only. This is for story 16519. Hopefully there won't be too many (or any) fixes to main branch while we develop on release-5.0.0 branch (which we will merge when it's safe to do so without breaking anything). |
severinbeauvais
changed the title
eve-git
approved these changes
Jun 23, 2023
For now, yes. Should I merge this and then create more PRs for the rest of the work in this ticket, or can I add extra work to THIS PR? (In case you don't want to see the extra work -- do you?) |
|
I agree that it is better to build a base first. |
severinbeauvais
changed the title
severinbeauvais
changed the title
|
This repo had unit test errors before the present changes. Using Node 12, before changes:
Update - I fixed the unit tests and some build issues:
|
|
Your package-lock has changed quite a bit - I'd recommend a decent retest. |
seeker25
reviewed
Jun 24, 2023
src/mixin-tester.vue
Outdated
|
|
||
| /** Special component used only for testing mixins. */ | ||
| @Component({}) | ||
| export default class MixinTester extends Mixins(DateMixin) {} |
There was a problem hiding this comment.
Shouldn't this live in TESTS? or is that not possible? Never tried to have a vue component in tests before though.
There was a problem hiding this comment.
Good call. Fixed.
seeker25
approved these changes
Jun 24, 2023
For sure. We will be making a lot of changes to this feature branch so it will undergo lots of testing. |
- used latest node version - updated browserslist - fixed a lint warning - created mixin-tester.vue - fixed date-mixin unit test errors - added babel plugin - updated axios, core-js, etc - updated types, test utils, etc - updated ts config - added volar config - changed some imports that gave errors - removed some "private" modifiers - added components.d.ts - deleted shims-tsx.d.ts - added vue-test-utils-helpers.d.ts - removed extra Vue.use() - misc cleanup
- moved interceptors.ts from sbc-common to local plugins to fix Axios version issue - other strict:true fixes - fixed property visibility issue - fixed catch clause variable issues - capitalized some plugin functions (eg, navigate -> Navigate) - fixed some visibility issues - misc cleanup
vysakh-menon-aot
approved these changes
Jun 26, 2023
JazzarKarim
approved these changes
Jun 26, 2023
- fixed empty object error - added misc code comments - changed some class property/method visibilities
JazzarKarim
pushed a commit
to JazzarKarim/namerequest
that referenced
this pull request
Aug 24, 2023
…-5.0.0") (bcgov#614) * - app version = 5.0.0 - used latest node version - updated browserslist - fixed a lint warning - created mixin-tester.vue - fixed date-mixin unit test errors - added babel plugin - updated axios, core-js, etc - updated types, test utils, etc - updated ts config - added volar config - changed some imports that gave errors - removed some "private" modifiers - added components.d.ts - deleted shims-tsx.d.ts - added vue-test-utils-helpers.d.ts - removed extra Vue.use() - misc cleanup * - moved mixin-tester.vue from src/ to tests/ - moved interceptors.ts from sbc-common to local plugins to fix Axios version issue - other strict:true fixes - fixed property visibility issue - fixed catch clause variable issues - capitalized some plugin functions (eg, navigate -> Navigate) - fixed some visibility issues - misc cleanup * - fixed whitespace around v-rows - fixed empty object error - added misc code comments - changed some class property/method visibilities
JazzarKarim
pushed a commit
to JazzarKarim/namerequest
that referenced
this pull request
Aug 24, 2023
…-5.0.0") (bcgov#614) * - app version = 5.0.0 - used latest node version - updated browserslist - fixed a lint warning - created mixin-tester.vue - fixed date-mixin unit test errors - added babel plugin - updated axios, core-js, etc - updated types, test utils, etc - updated ts config - added volar config - changed some imports that gave errors - removed some "private" modifiers - added components.d.ts - deleted shims-tsx.d.ts - added vue-test-utils-helpers.d.ts - removed extra Vue.use() - misc cleanup * - moved mixin-tester.vue from src/ to tests/ - moved interceptors.ts from sbc-common to local plugins to fix Axios version issue - other strict:true fixes - fixed property visibility issue - fixed catch clause variable issues - capitalized some plugin functions (eg, navigate -> Navigate) - fixed some visibility issues - misc cleanup * - fixed whitespace around v-rows - fixed empty object error - added misc code comments - changed some class property/method visibilities
JazzarKarim
pushed a commit
to JazzarKarim/namerequest
that referenced
this pull request
Aug 24, 2023
…-5.0.0") (bcgov#614) * - app version = 5.0.0 - used latest node version - updated browserslist - fixed a lint warning - created mixin-tester.vue - fixed date-mixin unit test errors - added babel plugin - updated axios, core-js, etc - updated types, test utils, etc - updated ts config - added volar config - changed some imports that gave errors - removed some "private" modifiers - added components.d.ts - deleted shims-tsx.d.ts - added vue-test-utils-helpers.d.ts - removed extra Vue.use() - misc cleanup * - moved mixin-tester.vue from src/ to tests/ - moved interceptors.ts from sbc-common to local plugins to fix Axios version issue - other strict:true fixes - fixed property visibility issue - fixed catch clause variable issues - capitalized some plugin functions (eg, navigate -> Navigate) - fixed some visibility issues - misc cleanup * - fixed whitespace around v-rows - fixed empty object error - added misc code comments - changed some class property/method visibilities
severinbeauvais
added a commit
that referenced
this pull request
Aug 24, 2023
* add two new alteration request types (#621) * remove currentAccount from session storage if token has expired (#637) * remove currentAccount from session storage if token has expired * 17088-update wording. (#634) * 17088-update wording. * Update package.json * Update font. * remove currentAccount from session storage if token has expired (#637) * remove currentAccount from session storage if token has expired * Update package-lock.json * 17088-update wording. * Update font. * Update package-lock.json * Update package-lock.json * Update version. --------- Co-authored-by: Andrew Bolyachevets <Andriy.Bolyachevets@gov.bc.ca> * 16634 Base changes for "way of navigating" story (new branch "release-5.0.0") (#614) * - app version = 5.0.0 - used latest node version - updated browserslist - fixed a lint warning - created mixin-tester.vue - fixed date-mixin unit test errors - added babel plugin - updated axios, core-js, etc - updated types, test utils, etc - updated ts config - added volar config - changed some imports that gave errors - removed some "private" modifiers - added components.d.ts - deleted shims-tsx.d.ts - added vue-test-utils-helpers.d.ts - removed extra Vue.use() - misc cleanup * - moved mixin-tester.vue from src/ to tests/ - moved interceptors.ts from sbc-common to local plugins to fix Axios version issue - other strict:true fixes - fixed property visibility issue - fixed catch clause variable issues - capitalized some plugin functions (eg, navigate -> Navigate) - fixed some visibility issues - misc cleanup * - fixed whitespace around v-rows - fixed empty object error - added misc code comments - changed some class property/method visibilities * 16634 Implemented new actions menu + cleanup (#616) * - app version = 5.0.2 - imported latest shared enums - changed RequestCode to shared NrRequestActionCodes enum - fixed some whitespace and alignment - fixed some property/method visibilities - cleanup up Pick Request Type dialog (removed blurbs, reformatted layout, filtered items) - implemented new v-select with list items for nested menus - implemented NameType enum for extraprovincial / assumed names - updated RequestActions data structure to support nested groups (and new text, etc) - fixed mobile spacing above nav buttons - fixed mobile spacing above existing NR buttons - misc cleanup - deleted obsolete code * - fixed slot item variable issues * - renamed new enum - reverted declarations * - removed await from non-async function - fixed another property visibility issue - fixed up PickRequestType modal - implemented some unit tests - moved and renamed some unit tests - misc cleanup * Imported latest codes + restored ULCB and ULBE (#630) * - app version = 5.0.9 - imported latest shared enums - restored conversion types ULCB and ULBE * - fixed conversion desc and text capitalizations * Fixed rebase issues + package version * fixed super small rebase issue --------- Co-authored-by: eve-git <54647458+eve-git@users.noreply.github.com> Co-authored-by: Andrew Bolyachevets <Andriy.Bolyachevets@gov.bc.ca> Co-authored-by: mengdong19 <meng.dong@gov.bc.ca> Co-authored-by: Séverin Beauvais <severinbeauvais@users.noreply.github.com>
severinbeauvais
added a commit
to severinbeauvais/namerequest
that referenced
this pull request
Aug 29, 2023
* add two new alteration request types (bcgov#621) * remove currentAccount from session storage if token has expired (bcgov#637) * remove currentAccount from session storage if token has expired * 17088-update wording. (bcgov#634) * 17088-update wording. * Update package.json * Update font. * remove currentAccount from session storage if token has expired (bcgov#637) * remove currentAccount from session storage if token has expired * Update package-lock.json * 17088-update wording. * Update font. * Update package-lock.json * Update package-lock.json * Update version. --------- Co-authored-by: Andrew Bolyachevets <Andriy.Bolyachevets@gov.bc.ca> * 16634 Base changes for "way of navigating" story (new branch "release-5.0.0") (bcgov#614) * - app version = 5.0.0 - used latest node version - updated browserslist - fixed a lint warning - created mixin-tester.vue - fixed date-mixin unit test errors - added babel plugin - updated axios, core-js, etc - updated types, test utils, etc - updated ts config - added volar config - changed some imports that gave errors - removed some "private" modifiers - added components.d.ts - deleted shims-tsx.d.ts - added vue-test-utils-helpers.d.ts - removed extra Vue.use() - misc cleanup * - moved mixin-tester.vue from src/ to tests/ - moved interceptors.ts from sbc-common to local plugins to fix Axios version issue - other strict:true fixes - fixed property visibility issue - fixed catch clause variable issues - capitalized some plugin functions (eg, navigate -> Navigate) - fixed some visibility issues - misc cleanup * - fixed whitespace around v-rows - fixed empty object error - added misc code comments - changed some class property/method visibilities * 16634 Implemented new actions menu + cleanup (bcgov#616) * - app version = 5.0.2 - imported latest shared enums - changed RequestCode to shared NrRequestActionCodes enum - fixed some whitespace and alignment - fixed some property/method visibilities - cleanup up Pick Request Type dialog (removed blurbs, reformatted layout, filtered items) - implemented new v-select with list items for nested menus - implemented NameType enum for extraprovincial / assumed names - updated RequestActions data structure to support nested groups (and new text, etc) - fixed mobile spacing above nav buttons - fixed mobile spacing above existing NR buttons - misc cleanup - deleted obsolete code * - fixed slot item variable issues * - renamed new enum - reverted declarations * - removed await from non-async function - fixed another property visibility issue - fixed up PickRequestType modal - implemented some unit tests - moved and renamed some unit tests - misc cleanup * Imported latest codes + restored ULCB and ULBE (bcgov#630) * - app version = 5.0.9 - imported latest shared enums - restored conversion types ULCB and ULBE * - fixed conversion desc and text capitalizations * Fixed rebase issues + package version * fixed super small rebase issue --------- Co-authored-by: eve-git <54647458+eve-git@users.noreply.github.com> Co-authored-by: Andrew Bolyachevets <Andriy.Bolyachevets@gov.bc.ca> Co-authored-by: mengdong19 <meng.dong@gov.bc.ca> Co-authored-by: Séverin Beauvais <severinbeauvais@users.noreply.github.com>
JazzarKarim
pushed a commit
to JazzarKarim/namerequest
that referenced
this pull request
Sep 8, 2023
…-5.0.0") (bcgov#614) * - app version = 5.0.0 - used latest node version - updated browserslist - fixed a lint warning - created mixin-tester.vue - fixed date-mixin unit test errors - added babel plugin - updated axios, core-js, etc - updated types, test utils, etc - updated ts config - added volar config - changed some imports that gave errors - removed some "private" modifiers - added components.d.ts - deleted shims-tsx.d.ts - added vue-test-utils-helpers.d.ts - removed extra Vue.use() - misc cleanup * - moved mixin-tester.vue from src/ to tests/ - moved interceptors.ts from sbc-common to local plugins to fix Axios version issue - other strict:true fixes - fixed property visibility issue - fixed catch clause variable issues - capitalized some plugin functions (eg, navigate -> Navigate) - fixed some visibility issues - misc cleanup * - fixed whitespace around v-rows - fixed empty object error - added misc code comments - changed some class property/method visibilities
JazzarKarim
added a commit
to JazzarKarim/namerequest
that referenced
this pull request
Sep 8, 2023
* add two new alteration request types (bcgov#621) * remove currentAccount from session storage if token has expired (bcgov#637) * remove currentAccount from session storage if token has expired * 17088-update wording. (bcgov#634) * 17088-update wording. * Update package.json * Update font. * remove currentAccount from session storage if token has expired (bcgov#637) * remove currentAccount from session storage if token has expired * Update package-lock.json * 17088-update wording. * Update font. * Update package-lock.json * Update package-lock.json * Update version. --------- Co-authored-by: Andrew Bolyachevets <Andriy.Bolyachevets@gov.bc.ca> * 16634 Base changes for "way of navigating" story (new branch "release-5.0.0") (bcgov#614) * - app version = 5.0.0 - used latest node version - updated browserslist - fixed a lint warning - created mixin-tester.vue - fixed date-mixin unit test errors - added babel plugin - updated axios, core-js, etc - updated types, test utils, etc - updated ts config - added volar config - changed some imports that gave errors - removed some "private" modifiers - added components.d.ts - deleted shims-tsx.d.ts - added vue-test-utils-helpers.d.ts - removed extra Vue.use() - misc cleanup * - moved mixin-tester.vue from src/ to tests/ - moved interceptors.ts from sbc-common to local plugins to fix Axios version issue - other strict:true fixes - fixed property visibility issue - fixed catch clause variable issues - capitalized some plugin functions (eg, navigate -> Navigate) - fixed some visibility issues - misc cleanup * - fixed whitespace around v-rows - fixed empty object error - added misc code comments - changed some class property/method visibilities * 16634 Implemented new actions menu + cleanup (bcgov#616) * - app version = 5.0.2 - imported latest shared enums - changed RequestCode to shared NrRequestActionCodes enum - fixed some whitespace and alignment - fixed some property/method visibilities - cleanup up Pick Request Type dialog (removed blurbs, reformatted layout, filtered items) - implemented new v-select with list items for nested menus - implemented NameType enum for extraprovincial / assumed names - updated RequestActions data structure to support nested groups (and new text, etc) - fixed mobile spacing above nav buttons - fixed mobile spacing above existing NR buttons - misc cleanup - deleted obsolete code * - fixed slot item variable issues * - renamed new enum - reverted declarations * - removed await from non-async function - fixed another property visibility issue - fixed up PickRequestType modal - implemented some unit tests - moved and renamed some unit tests - misc cleanup * Imported latest codes + restored ULCB and ULBE (bcgov#630) * - app version = 5.0.9 - imported latest shared enums - restored conversion types ULCB and ULBE * - fixed conversion desc and text capitalizations * Fixed rebase issues + package version * fixed super small rebase issue --------- Co-authored-by: eve-git <54647458+eve-git@users.noreply.github.com> Co-authored-by: Andrew Bolyachevets <Andriy.Bolyachevets@gov.bc.ca> Co-authored-by: mengdong19 <meng.dong@gov.bc.ca> Co-authored-by: Séverin Beauvais <severinbeauvais@users.noreply.github.com>
JazzarKarim
pushed a commit
that referenced
this pull request
Sep 11, 2023
…-5.0.0") (#614) * - app version = 5.0.0 - used latest node version - updated browserslist - fixed a lint warning - created mixin-tester.vue - fixed date-mixin unit test errors - added babel plugin - updated axios, core-js, etc - updated types, test utils, etc - updated ts config - added volar config - changed some imports that gave errors - removed some "private" modifiers - added components.d.ts - deleted shims-tsx.d.ts - added vue-test-utils-helpers.d.ts - removed extra Vue.use() - misc cleanup * - moved mixin-tester.vue from src/ to tests/ - moved interceptors.ts from sbc-common to local plugins to fix Axios version issue - other strict:true fixes - fixed property visibility issue - fixed catch clause variable issues - capitalized some plugin functions (eg, navigate -> Navigate) - fixed some visibility issues - misc cleanup * - fixed whitespace around v-rows - fixed empty object error - added misc code comments - changed some class property/method visibilities
JazzarKarim
added a commit
that referenced
this pull request
Sep 11, 2023
* add two new alteration request types (#621) * remove currentAccount from session storage if token has expired (#637) * remove currentAccount from session storage if token has expired * 17088-update wording. (#634) * 17088-update wording. * Update package.json * Update font. * remove currentAccount from session storage if token has expired (#637) * remove currentAccount from session storage if token has expired * Update package-lock.json * 17088-update wording. * Update font. * Update package-lock.json * Update package-lock.json * Update version. --------- Co-authored-by: Andrew Bolyachevets <Andriy.Bolyachevets@gov.bc.ca> * 16634 Base changes for "way of navigating" story (new branch "release-5.0.0") (#614) * - app version = 5.0.0 - used latest node version - updated browserslist - fixed a lint warning - created mixin-tester.vue - fixed date-mixin unit test errors - added babel plugin - updated axios, core-js, etc - updated types, test utils, etc - updated ts config - added volar config - changed some imports that gave errors - removed some "private" modifiers - added components.d.ts - deleted shims-tsx.d.ts - added vue-test-utils-helpers.d.ts - removed extra Vue.use() - misc cleanup * - moved mixin-tester.vue from src/ to tests/ - moved interceptors.ts from sbc-common to local plugins to fix Axios version issue - other strict:true fixes - fixed property visibility issue - fixed catch clause variable issues - capitalized some plugin functions (eg, navigate -> Navigate) - fixed some visibility issues - misc cleanup * - fixed whitespace around v-rows - fixed empty object error - added misc code comments - changed some class property/method visibilities * 16634 Implemented new actions menu + cleanup (#616) * - app version = 5.0.2 - imported latest shared enums - changed RequestCode to shared NrRequestActionCodes enum - fixed some whitespace and alignment - fixed some property/method visibilities - cleanup up Pick Request Type dialog (removed blurbs, reformatted layout, filtered items) - implemented new v-select with list items for nested menus - implemented NameType enum for extraprovincial / assumed names - updated RequestActions data structure to support nested groups (and new text, etc) - fixed mobile spacing above nav buttons - fixed mobile spacing above existing NR buttons - misc cleanup - deleted obsolete code * - fixed slot item variable issues * - renamed new enum - reverted declarations * - removed await from non-async function - fixed another property visibility issue - fixed up PickRequestType modal - implemented some unit tests - moved and renamed some unit tests - misc cleanup * Imported latest codes + restored ULCB and ULBE (#630) * - app version = 5.0.9 - imported latest shared enums - restored conversion types ULCB and ULBE * - fixed conversion desc and text capitalizations * Fixed rebase issues + package version * fixed super small rebase issue --------- Co-authored-by: eve-git <54647458+eve-git@users.noreply.github.com> Co-authored-by: Andrew Bolyachevets <Andriy.Bolyachevets@gov.bc.ca> Co-authored-by: mengdong19 <meng.dong@gov.bc.ca> Co-authored-by: Séverin Beauvais <severinbeauvais@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#16634
The "way of navigating" story (16519) contains many tickets that cannot be merged to main branch without breaking things. Hence, THIS pull request implements some base changes, including a new feature branch, for those changes. When the feature branch is working correctly, then it will be merged into main branch.
Description of changes:
Commit 1:
- app version = 5.0.0
- used latest node version
- updated browserslist
- fixed a lint warning
- created mixin-tester.vue
- fixed date-mixin unit test errors
- added babel plugin
- updated axios, core-js, etc
- updated types, test utils, etc
- updated ts config
- added volar config
- changed some imports that gave errors
- removed some "private" modifiers
- added components.d.ts
- deleted shims-tsx.d.ts
- added vue-test-utils-helpers.d.ts
- removed extra Vue.use()
- misc cleanup
Commit 2:
- moved mixin-tester.vue from src/ to tests/
- moved interceptors.ts from sbc-common to local plugins to fix Axios version issue
- other strict:true fixes
- fixed property visibility issue
- fixed catch clause variable issues
- capitalized some plugin functions (eg, navigate -> Navigate)
- fixed some visibility issues
- misc cleanup
Commit 3:
- fixed whitespace around v-rows
- fixed empty object error
- added misc code comments
- changed some more class property/method visibilities
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).