16634 mapped EntityType to CorpTypeCd + cleanup #622

severinbeauvais · 2023-07-06T15:47:54Z

Description of changes:

Commit 1:

updated browserslist config
app version = 5.0.3
added corp-type-module dependency
mapped EntityType to CorpTypeCd

Commit 2:

renamed xxx.services -> xxx-services
changed some strings to EntityType
worked around EntityType type issue
sorted items in entityTypeCdToText()

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

- app version = 5.0.3 - added corp-type-module dependency - mapped EntityType to CorpTypeCd

severinbeauvais · 2023-07-06T15:49:38Z

Sorry about the large list of reviewers, but this is a small (but possibly significant) change that I think you should know about, since you are touching, or have recently touched, this repo. Thx.

severinbeauvais · 2023-07-06T15:50:14Z

.browserslistrc

@@ -1,3 +1,3 @@
 > 1%
 last 2 versions
-not ie <= 10
+not dead


Same as other UI repos.

severinbeauvais · 2023-07-06T15:51:24Z

package-lock.json

@@ -1,14 +1,15 @@
 {
 "name": "name-request",
- "version": "5.0.2",
+ "version": "5.0.3",
 "lockfileVersion": 2,


Note that someone, somewhere along the line, did a npm i while on Node < v16, which changed the lockfile to version 1 in main branch. This is a feature branch and it's OK here. At some point, main branch should be fixed, or maybe this can wait until this feature branch is merged into main in about a month.

severinbeauvais · 2023-07-06T15:53:37Z

src/enums/entity-type.ts

I made these changes to be explicit about the entity type codes used in Namerequest vs. LEAR.

If you look at corp-type-module.ts then you will see that LEAR knows about some NR-only codes, but below you can see there are others. As far as I know, these haven't caused problems between NR and LEAR, but some day they might. And now it's easier to see the difference between the two.

severinbeauvais · 2023-07-06T16:50:08Z

For some reason, TS and eslint are happy with this code, but the build process isn't. I'm trying to resolve this. Don't merge yet.

Update: fixed. See comments below.

JazzarKarim · 2023-07-06T18:12:03Z

src/enums/entity-type.ts

- LP = 'LP',
- PA = 'PA',
- PAR = 'PAR',
+ BC = CorpTypeCd.BC_COMPANY,


This makes things much easier and cleaner for proceeding with the way of navigating work 😁

I think we'll have to change the value of the supported-incorporation-registration-entities FF we created. Also, I'm going to make the necessary changes in my two tickets to accompany this adjustment after you merge Sev 👍

OK. Let me know about that existing FF, and whether we need another one for something different.

~~I haven't figured out the build issue yet...~~ solved

severinbeauvais · 2023-07-06T19:25:52Z

For some reason, TS and eslint are happy with this code, but the build process isn't. I'm trying to resolve this. Don't merge yet.

It seems the build process doesn't want to mix enum-strings with pure-strings, so I did this and it's happy with it:

// Namerequest-only entity types
enum Other {
  SO = 'SO',
  XUL = 'XUL',
  RLC = 'RLC',
  XLP = 'XLP',
  XLL = 'XLL',
  XSO = 'XSO',
  INFO = 'INFO'
}

/** Enum for Entity Type codes. */
export enum EntityType {
  // BC Entity Types:
  BC = CorpTypeCd.BC_COMPANY,
  ...
  SO = Other.SO,

In other words, the EntityType enum takes values from other enums, instead of a mix of enum/string.

severinbeauvais · 2023-07-06T19:31:01Z

I have tested this locally and it works fine.

severinbeauvais · 2023-07-06T19:38:14Z

src/mixins/common-mixin.ts

@@ -87,6 +89,7 @@ export class CommonMixin extends Vue {
 isFirm (nr: any): boolean {
 return (
 nr?.legalType === EntityType.SP ||
+ nr?.legalType === EntityType.DBA ||


Not sure if this was accidentally missed but it can't hurt to have it. 🤞

- changed some strings to EntityType - worked around EntityType type issue - sorted items in entityTypeCdToText()

JazzarKarim

LGTM 👍

chenhongjing

LGTM 🐱

Madhavkapoor28 · 2023-07-06T21:26:51Z

LGTM!

* - updated browserslist config - app version = 5.0.3 - added corp-type-module dependency - mapped EntityType to CorpTypeCd * - renamed xxx.services -> xxx-services - changed some strings to EntityType - worked around EntityType type issue - sorted items in entityTypeCdToText()

- updated browserslist config

4b50d37

- app version = 5.0.3 - added corp-type-module dependency - mapped EntityType to CorpTypeCd

severinbeauvais self-assigned this Jul 6, 2023

severinbeauvais requested review from seeker25, eve-git, JazzarKarim, pwei1018, mengdong19, Madhavkapoor28 and chenhongjing July 6, 2023 15:48

severinbeauvais commented Jul 6, 2023

View reviewed changes

.browserslistrc

@@ -1,3 +1,3 @@

> 1%

last 2 versions

not ie <= 10

not dead

Copy link

Collaborator Author

severinbeauvais Jul 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as other UI repos.

severinbeauvais commented Jul 6, 2023

View reviewed changes

severinbeauvais added the Do Not Merge label Jul 6, 2023

JazzarKarim reviewed Jul 6, 2023

View reviewed changes

severinbeauvais removed the Do Not Merge label Jul 6, 2023

severinbeauvais changed the title ~~16634 mapped EntityType to CorpTypeCd~~ 16634 mapped EntityType to CorpTypeCd + cleanup Jul 6, 2023

severinbeauvais commented Jul 6, 2023

View reviewed changes

- renamed xxx.services -> xxx-services

0a77aba

- changed some strings to EntityType - worked around EntityType type issue - sorted items in entityTypeCdToText()

severinbeauvais force-pushed the 16634 branch from 0937cdb to 0a77aba Compare July 6, 2023 19:38

JazzarKarim approved these changes Jul 6, 2023

View reviewed changes

chenhongjing approved these changes Jul 6, 2023

View reviewed changes

severinbeauvais merged commit 35a7737 into bcgov:feature-way-of-navigating Jul 6, 2023
4 of 5 checks passed

severinbeauvais mentioned this pull request Jul 7, 2023

17137 Updated misc Corp Type Codes bcgov/bcrs-shared-components#187

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

16634 mapped EntityType to CorpTypeCd + cleanup #622

16634 mapped EntityType to CorpTypeCd + cleanup #622

severinbeauvais commented Jul 6, 2023 •

edited

Loading

severinbeauvais commented Jul 6, 2023

severinbeauvais Jul 6, 2023

severinbeauvais Jul 6, 2023

severinbeauvais Jul 6, 2023

severinbeauvais commented Jul 6, 2023 •

edited

Loading

JazzarKarim Jul 6, 2023

severinbeauvais Jul 6, 2023 •

edited

Loading

severinbeauvais commented Jul 6, 2023 •

edited

Loading

severinbeauvais commented Jul 6, 2023

severinbeauvais Jul 6, 2023 •

edited

Loading

JazzarKarim left a comment

chenhongjing left a comment

Madhavkapoor28 commented Jul 6, 2023

16634 mapped EntityType to CorpTypeCd + cleanup #622

16634 mapped EntityType to CorpTypeCd + cleanup #622

Conversation

severinbeauvais commented Jul 6, 2023 • edited Loading

severinbeauvais commented Jul 6, 2023

severinbeauvais Jul 6, 2023

Choose a reason for hiding this comment

severinbeauvais Jul 6, 2023

Choose a reason for hiding this comment

severinbeauvais Jul 6, 2023

Choose a reason for hiding this comment

severinbeauvais commented Jul 6, 2023 • edited Loading

JazzarKarim Jul 6, 2023

Choose a reason for hiding this comment

severinbeauvais Jul 6, 2023 • edited Loading

Choose a reason for hiding this comment

severinbeauvais commented Jul 6, 2023 • edited Loading

severinbeauvais commented Jul 6, 2023

severinbeauvais Jul 6, 2023 • edited Loading

Choose a reason for hiding this comment

JazzarKarim left a comment

Choose a reason for hiding this comment

chenhongjing left a comment

Choose a reason for hiding this comment

Madhavkapoor28 commented Jul 6, 2023

severinbeauvais commented Jul 6, 2023 •

edited

Loading

severinbeauvais commented Jul 6, 2023 •

edited

Loading

severinbeauvais Jul 6, 2023 •

edited

Loading

severinbeauvais commented Jul 6, 2023 •

edited

Loading

severinbeauvais Jul 6, 2023 •

edited

Loading