17489 Partial Business Fetch component + clear button #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
severinbeauvais
requested review from
ketaki-deodhar,
chenhongjing and
JazzarKarim
severinbeauvais
commented
Aug 25, 2023
|
|
||
| // set state and perform search | ||
| this.state = States.SEARCHING | ||
| await Sleep(1000) // *** TODO: perform search here |
There was a problem hiding this comment.
WIP but partly usable :)
- implemented partial Business Fetch component - deleted BusinessLookup from store - used Business Fetch component when not logged in - implemented business lookup/fetch clear button
severinbeauvais
commented
Aug 25, 2023
| bn: '', | ||
| status: EntityStates.ACTIVE, | ||
| name: this.searchField | ||
| } |
There was a problem hiding this comment.
For testing, using a business ID as search field.
severinbeauvais
commented
Aug 25, 2023
| :value="business.name" | ||
| /> | ||
| <div @click="business=null"> | ||
| <v-icon color="primary">mdi-close</v-icon> |
There was a problem hiding this comment.
This is a usable clear/retry button, but I'm still waiting for Janis' design on it.
severinbeauvais
commented
Aug 25, 2023
| @@ -15,7 +15,6 @@ export interface NewRequestIF { | |||
| analysisJSON: AnalysisJSONI | |||
| applicant: ApplicantI | |||
| assumedNameOriginal: string | |||
| businessLookup: BusinessLookupResultIF | |||
There was a problem hiding this comment.
I think we don't need this in the store -- its lifespan is only while doing a business lookup on the Search page. After that, other variables are set from the data.
|
Merging! |
ketaki-deodhar
merged commit a1e0964
into
bcgov:feature-way-of-navigating
4 of 5 checks passed
severinbeauvais
added a commit
to severinbeauvais/namerequest
that referenced
this pull request
Aug 29, 2023
- implemented partial Business Fetch component - deleted BusinessLookup from store - used Business Fetch component when not logged in - implemented business lookup/fetch clear button
JazzarKarim
pushed a commit
to JazzarKarim/namerequest
that referenced
this pull request
Sep 8, 2023
- implemented partial Business Fetch component - deleted BusinessLookup from store - used Business Fetch component when not logged in - implemented business lookup/fetch clear button
JazzarKarim
pushed a commit
that referenced
this pull request
Sep 11, 2023
- implemented partial Business Fetch component - deleted BusinessLookup from store - used Business Fetch component when not logged in - implemented business lookup/fetch clear button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: bcgov/entity#17489
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).