17468 fixed Entity Type menu #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- simplified entity type menu bindings - fixed entity type reactivity bug - misc cleanup
severinbeauvais
changed the base branch from
main
to
feature-way-of-navigating
severinbeauvais
commented
Sep 7, 2023
| hide-details="auto" | ||
| filled | ||
| v-model="entity_type_options_select_bind" | ||
| :value="isConversion ? getOriginEntityTypeCd : entity_type_cd" | ||
| @change="setClearErrors(); entity_type_cd = $event" |
There was a problem hiding this comment.
One less level of indirection (instead of get + set).
severinbeauvais
commented
Sep 7, 2023
| @@ -274,7 +275,8 @@ | |||
| :href="colinLink" | |||
| target="_blank" | |||
| > | |||
| Go to Corporate Online to {{ goToColinText }} <v-icon small class="ml-1">mdi-open-in-new</v-icon> | |||
| Go to Corporate Online to {{ isConversion ? 'Alter' : 'Register' }} | |||
| <v-icon small class="ml-1">mdi-open-in-new</v-icon> | |||
There was a problem hiding this comment.
Moved very simple function code into here (only place it was used).
severinbeauvais
commented
Sep 7, 2023
| if (this.isContinuationIn) return 'Continue In Now' | ||
| if (this.isAmalgamation) return 'Amalgamate Now' | ||
| if (this.isConversion) return 'Alter Now' | ||
| if (this.isRestoration) return 'Restore Now' | ||
| return 'Incorporate Now' |
There was a problem hiding this comment.
Easier pattern to read/understand/extend.
severinbeauvais
requested review from
chenhongjing,
ketaki-deodhar and
JazzarKarim
|
|
severinbeauvais
commented
Sep 7, 2023
| @@ -1,12 +1,12 @@ | |||
| <template> | |||
| <v-dialog v-model="showModal" :max-width="width" persistent> | |||
| <v-dialog :value="getPickEntityModalVisible" :max-width="width" persistent> | |||
There was a problem hiding this comment.
Dialog doesn't set this value so can use store getter directly here.
severinbeauvais
commented
Sep 7, 2023
| closeIconClicked () { | ||
| this.setPickEntityModalVisible(false) | ||
| // clear "View all business types" selection | ||
| this.setEntityTypeCd(null) |
There was a problem hiding this comment.
Compare this to search.vue where we set this to empty string. This maintains reactivity, so the v-select clears itself correctly.
severinbeauvais
commented
Sep 7, 2023
|
|
||
| set showModal (value: boolean) { | ||
| this.setPickEntityModalVisible(value) | ||
| } |
There was a problem hiding this comment.
I just used the store getter/action directly.
|
/gcbrun |
|
Temporary Url for review: https://namerequest-dev--pr-673-kfkjfou9.web.app |
severinbeauvais
merged commit 6dac03a
into
bcgov:feature-way-of-navigating
5 checks passed
JazzarKarim
pushed a commit
to JazzarKarim/namerequest
that referenced
this pull request
Sep 8, 2023
* - app version = 5.0.37 - simplified entity type menu bindings - fixed entity type reactivity bug - misc cleanup * - cleaned up / fixed modal bindings
JazzarKarim
pushed a commit
that referenced
this pull request
Sep 11, 2023
* - app version = 5.0.37 - simplified entity type menu bindings - fixed entity type reactivity bug - misc cleanup * - cleaned up / fixed modal bindings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: bcgov/entity#17468
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).