18205 Fixed incorrect entity types #730
Conversation
- changed SP -> FR in Business Lookup list - changed ULC-> UL in Business Lookup list
|
/gcbrun |
|
Temporary Url for review: https://namerequest-dev--pr-730-cvs5k9nw.web.app |
| EntityTypes.C, | ||
| EntityTypes.CC, | ||
| EntityTypes.CCC, | ||
| EntityTypes.CUL, | ||
| EntityTypes.CP, | ||
| EntityTypes.CR, | ||
| EntityTypes.CR, // BC Limited Company | ||
| EntityTypes.FR, // Sole Proprietorship |
There was a problem hiding this comment.
I tested FR by creating a name change NR for FM1056109 and verifying that corpnum was populated.
| EntityTypes.GP, | ||
| EntityTypes.LLC, | ||
| EntityTypes.LP, | ||
| EntityTypes.PA, | ||
| EntityTypes.PAR, | ||
| EntityTypes.SO, | ||
| EntityTypes.SP, | ||
| EntityTypes.ULC, | ||
| EntityTypes.UL, |
There was a problem hiding this comment.
I tested UL by creating a name change NR for BC0871495 and verifying that corpnum was populated.
| EntityTypes.BC, | ||
| EntityTypes.BEN, | ||
| EntityTypes.BC, // Benefit Company | ||
| EntityTypes.BEN, // invalid? |
There was a problem hiding this comment.
I think BEN is invalid here but I'm not about to remove it in a hotfix without fully understanding how this list is used 😛
I also checked the other entries in this list, and I think they're OK, but there may be some types missing.
There was a problem hiding this comment.
Yeah I agree I had a brief look through namex and I don't believe BEN is valid, but it is probably not worth removing on a hotfix.
Issue #: bcgov/entity#18205
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).