18235 fixed more entity type / corp type mappings #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated "not restorable" error text (per Janis) - added missing mapping to isChangeNameXpro() - added missing mapping to isSelectedXproAndRestorable()
|
/gcbrun |
severinbeauvais
commented
Oct 19, 2023
| @@ -62,7 +62,7 @@ export default class BusinessLookupFetch extends Mixins(CommonMixin, SearchMixin | |||
| if (this.isConversion) { | |||
| return this.isAlterable || 'This business cannot alter their business type' | |||
| } else if (this.isRestoration) { | |||
| return this.isRestorable || 'This business cannot be restored' | |||
| return this.isRestorable || 'This business cannot be reactivated' | |||
There was a problem hiding this comment.
Per Janis, this is to cover "restorations" and "reinstatements".
|
Temporary Url for review: https://namerequest-dev--pr-733-estcaefy.web.app |
JazzarKarim
approved these changes
Oct 19, 2023
eve-git
approved these changes
Oct 19, 2023
severinbeauvais
commented
Oct 19, 2023
| @@ -158,7 +158,8 @@ export class SearchMixin extends Mixins(CommonMixin) { | |||
| } | |||
|
|
|||
| get isChangeNameXpro (): boolean { | |||
| return XproMapping.CHG.includes(this.getSearchBusiness?.legalType) | |||
There was a problem hiding this comment.
This would have worked for the types that are the same between Namerequest and LEAR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: bcgov/entity#18235
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).