18299 fix xpro A -> XCR mapping #736

severinbeauvais · 2023-10-24T17:03:18Z

NOTE: this PR is being merged into release-5.2.14 branch so that I can deploy it to Test and Prod with no other commits in it since the last Prod version.

Description of changes:

app version = 5.2.14.a
fixed Xpro REH and CHG mapping: XUL should be XCR
fixed entity type to corp type mapping:
- removed entity type A,
- XCR should map to EXTRA_PRO_A and
- XUL should map to XPRO_UNLIMITED_LIABILITY_COMPANY
fixed corp type to entity type mapping:
- EXTRA_PRO_A should map to XCR and
- XPRO_UNLIMITED_LIABILITY_COMPANY should map to XUL

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

severinbeauvais · 2023-10-24T17:33:05Z

package.json

@@ -1,6 +1,6 @@
 {
 "name": "name-request",
- "version": "5.2.14",
+ "version": "5.2.14a",


Because this is a hotfix and there is already a 5.2.15.

severinbeauvais · 2023-10-24T17:34:12Z

src/list-data/request-action-mapping.ts

@@ -76,16 +76,16 @@ export const XproMapping: RequestActionMappingI = {
 REH: [
 EntityTypes.RLC, // maps to Corp Type "LLC"
 EntityTypes.XCP, // maps to Corp Type "XCP"
- EntityTypes.XSO, // maps to Corp Type "XS"
- EntityTypes.XUL // maps to Corp Type "A"
+ EntityTypes.XCR, // maps to Corp Type "EXTRA_PRO_A"


XCR === A

I sorted this list.

I removed XUL from below as per original NR code (before WoN changes).

severinbeauvais · 2023-10-24T17:34:36Z

src/mixins/common-mixin.ts

@@ -59,7 +59,6 @@ export class CommonMixin extends Vue {
 */
 entityTypeToCorpType (entityType: EntityTypes): CorpTypeCd {
 switch (entityType) {
- case EntityTypes.A: return CorpTypeCd.EXTRA_PRO_A // same as XUL


I believe this is not a valid Namerequest entity type.

severinbeauvais · 2023-10-24T17:34:43Z

src/mixins/common-mixin.ts

@@ -77,13 +76,13 @@ export class CommonMixin extends Vue {
 case EntityTypes.SO: return CorpTypeCd.SOCIETY
 case EntityTypes.UL: return CorpTypeCd.BC_ULC_COMPANY
 case EntityTypes.XCP: return CorpTypeCd.XPRO_COOP
- case EntityTypes.XCR: return CorpTypeCd.XPRO_CORPORATION
+ case EntityTypes.XCR: return CorpTypeCd.EXTRA_PRO_A


Ah man. Again, these can be soo confusing. On paper it sounds like EXTRA_PRO_A is EntityTypes.A, but apparently that's not the case. Just like how BC is a benefit company but CR is a limited company.

severinbeauvais · 2023-10-24T17:35:08Z

src/mixins/common-mixin.ts

 case EntityTypes.XL: return CorpTypeCd.XPRO_LL_PARTNR // same as XLL
 case EntityTypes.XLL: return CorpTypeCd.XPRO_LL_PARTNR
 case EntityTypes.XLP: return CorpTypeCd.XPRO_LIM_PARTNR
 case EntityTypes.XP: return CorpTypeCd.XPRO_LIM_PARTNR // same as XLP
 case EntityTypes.XSO: return CorpTypeCd.XPRO_SOCIETY
- case EntityTypes.XUL: return CorpTypeCd.EXTRA_PRO_A
+ case EntityTypes.XUL: return CorpTypeCd.XPRO_UNLIMITED_LIABILITY_COMPANY


I believe this is the correct mapping, although I think we don't actually use XUL in Namerequest.

To be precise, Namex API seems to support XUL <-> A mappings, ie

However, the XUL <-> XUL mapping entries in Legal API are currently commented out, meaning they're not supported in Lear atm, ie

Interestingly, the XCR <-> XCR mapping entries in Lear are also commented out. This makes sense, since users need to go to COLIN to use XCR name requests... We will likely revisit this when we move over the final types from COLIN to LEAR. Good luck to us!

A problem to keep in mind for the future haha 😅

severinbeauvais · 2023-10-24T17:35:16Z

src/mixins/common-mixin.ts

@@ -99,7 +98,7 @@ export class CommonMixin extends Vue {
 case CorpTypeCd.BC_COMPANY: return EntityTypes.CR
 case CorpTypeCd.BC_ULC_COMPANY: return EntityTypes.UL
 case CorpTypeCd.COOP: return EntityTypes.CP
- case CorpTypeCd.EXTRA_PRO_A: return EntityTypes.XUL
+ case CorpTypeCd.EXTRA_PRO_A: return EntityTypes.XCR


- fixed entity type to corp type mapping: removed entity type A, XCR should map to EXTRA_PRO_A and XUL should map to XPRO_UNLIMITED_LIABILITY_COMPANY - fixed corp type to entity type mapping: EXTRA_PRO_A should map to XCR and XPRO_UNLIMITED_LIABILITY_COMPANY should map to XUL

severinbeauvais · 2023-10-24T17:36:47Z

src/mixins/common-mixin.ts

+ EntityTypes.XLL,
+ EntityTypes.XLP,
+ EntityTypes.XSO,
+ EntityTypes.XUL


I simply sorted this list.

I left XUL in there even though I I think we don't actually use it in Namerequest.

severinbeauvais · 2023-10-24T17:39:42Z

To test this...

I created the following name change NR for an A company:

I created the following restoration NR for an A company:

JazzarKarim

LGTM Sev!

ozamani9gh

thanks sev looks good

- app version = 5.2.14.a

fe42155

severinbeauvais self-assigned this Oct 24, 2023

severinbeauvais requested review from leodube-aot, eve-git, ozamani9gh and JazzarKarim October 24, 2023 17:32

severinbeauvais commented Oct 24, 2023

View reviewed changes

severinbeauvais force-pushed the 18299 branch from f6d2dc7 to 064e2e6 Compare October 24, 2023 17:36

severinbeauvais commented Oct 24, 2023

View reviewed changes

severinbeauvais marked this pull request as ready for review October 24, 2023 17:37

JazzarKarim approved these changes Oct 24, 2023

View reviewed changes

severinbeauvais changed the title ~~18299 fix xpro A company mapping~~ 18299 fix xpro A -> XCR mapping Oct 24, 2023

eve-git approved these changes Oct 24, 2023

View reviewed changes

severinbeauvais merged commit 16623ba into bcgov:release-5.2.14 Oct 24, 2023
4 checks passed

ozamani9gh approved these changes Oct 24, 2023

View reviewed changes

severinbeauvais mentioned this pull request Oct 24, 2023

18299 fix xpro A -> XCR mapping #738

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

18299 fix xpro A -> XCR mapping #736

18299 fix xpro A -> XCR mapping #736

severinbeauvais commented Oct 24, 2023 •

edited

Loading

severinbeauvais Oct 24, 2023

severinbeauvais Oct 24, 2023 •

edited

Loading

severinbeauvais Oct 24, 2023 •

edited

Loading

severinbeauvais Oct 24, 2023

JazzarKarim Oct 24, 2023 •

edited

Loading

severinbeauvais Oct 24, 2023

severinbeauvais Oct 24, 2023

severinbeauvais Oct 24, 2023 •

edited

Loading

JazzarKarim Oct 24, 2023

severinbeauvais Oct 24, 2023

severinbeauvais Oct 24, 2023 •

edited

Loading

severinbeauvais commented Oct 24, 2023 •

edited

Loading

JazzarKarim left a comment

ozamani9gh left a comment

18299 fix xpro A -> XCR mapping #736

18299 fix xpro A -> XCR mapping #736

Conversation

severinbeauvais commented Oct 24, 2023 • edited Loading

severinbeauvais Oct 24, 2023

Choose a reason for hiding this comment

severinbeauvais Oct 24, 2023 • edited Loading

Choose a reason for hiding this comment

severinbeauvais Oct 24, 2023 • edited Loading

Choose a reason for hiding this comment

severinbeauvais Oct 24, 2023

Choose a reason for hiding this comment

JazzarKarim Oct 24, 2023 • edited Loading

Choose a reason for hiding this comment

severinbeauvais Oct 24, 2023

Choose a reason for hiding this comment

severinbeauvais Oct 24, 2023

Choose a reason for hiding this comment

severinbeauvais Oct 24, 2023 • edited Loading

Choose a reason for hiding this comment

JazzarKarim Oct 24, 2023

Choose a reason for hiding this comment

severinbeauvais Oct 24, 2023

Choose a reason for hiding this comment

severinbeauvais Oct 24, 2023 • edited Loading

Choose a reason for hiding this comment

severinbeauvais commented Oct 24, 2023 • edited Loading

JazzarKarim left a comment

Choose a reason for hiding this comment

ozamani9gh left a comment

Choose a reason for hiding this comment

severinbeauvais commented Oct 24, 2023 •

edited

Loading

severinbeauvais Oct 24, 2023 •

edited

Loading

severinbeauvais Oct 24, 2023 •

edited

Loading

JazzarKarim Oct 24, 2023 •

edited

Loading

severinbeauvais Oct 24, 2023 •

edited

Loading

severinbeauvais Oct 24, 2023 •

edited

Loading

severinbeauvais commented Oct 24, 2023 •

edited

Loading