14923 changed char limit #1408
Merged
14923 changed char limit #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madhavkapoor28
requested review from
pwei1018,
eve-git,
thorwolpert,
stevenc987,
mengdong19,
ozamani9gh and
rarmitag
as code owners
ozamani9gh
approved these changes
Aug 29, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -114,7 +114,7 @@ class Request(db.Model): | |||
| checkedOutDt = db.Column('checked_out_dt', db.DateTime(timezone=True),index=True) | |||
|
|
|||
| # MRAS fields | |||
| homeJurisNum = db.Column('home_juris_num', db.String(40)) | |||
| homeJurisNum = db.Column('home_juris_num', db.String(150)) | |||
There was a problem hiding this comment.
Hey wait a minute. I saw a Namerequest UI PR recently that changed this from 150 to 40. Which is correct???
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #14923
Description of changes:
Changed char limit from 40 to 150 for the homeJurisNum column.