Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed date formation for expiration date #1533

Merged
merged 3 commits into from
May 23, 2024

Conversation

flutistar
Copy link
Collaborator

@flutistar flutistar commented May 22, 2024

*Issue #: 20887
Description of changes:
Removed unnecessary date formation on PUT API.

NOTE: datetime.datetime.strptime doesn't work with timezone(%z works properly but %Z doesn't), I converted the date format to ISO instead of UTC.

Another PR that is made on Name Examination that pairs with this PR.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

Copy link
Collaborator

@eve-git eve-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@flutistar flutistar merged commit 40cb721 into bcgov:main May 23, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants