Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search no longer filters names with synonyms from multiple synonym lists #518

Merged

Conversation

kialj876
Copy link
Collaborator

@kialj876 kialj876 commented Feb 6, 2019

Signed-off-by: Kial Jinnah kialj876@gmail.com

Issue #, if available:bcgov/entity#69 bcgov/entity#74

Description of changes:

  • fixed bug where search would filter out names that included synonyms part of more than 1 synonym list (if a name was returned because it had a synonym of what was searched and that synonym was not in the first list of synonyms for that word it would get filtered out)
  • pytests added/pass locally
  • logging error message also fixed

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

Signed-off-by: Kial Jinnah <kialj876@gmail.com>
@katiemcgoff katiemcgoff merged commit 5be5931 into bcgov:master Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants