104/147 - stems before synonym, number fix, bug on filtering conflict… #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… list fix Signed-off-by: Kial Jinnah <kialj876@gmail.com>
katiemcgoff
suggested changes
Feb 15, 2019
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… list fix
Signed-off-by: Kial Jinnah kialj876@gmail.com
Issue #, if available:bcgov/entity#104 bcgov/entity#147
Description of changes:
synonyms are found based on their stems ('trucking' will match on 'truck' synonym list)
missed results are added to the bottom of the list instead of being filtered out
less solr calls made from solr.py (speeds up conflict search)
when doing a wildcard search proximity search does not run (increases speed and visually more clear)
numbers are no longer split from letters in conflict search (5th = 5th/fifth/5, 5th != 5 th)
pytests added
2 pytests fail locally because I don't have oracle running
1 pytest fails because solr-admin-app stems needs to rerun stems script after this pr is accepted
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).