Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FSADT1-1528): updating complex search from predictive #1219

Merged
merged 8 commits into from
Oct 8, 2024
Merged

feat(FSADT1-1528): updating complex search from predictive #1219

merged 8 commits into from
Oct 8, 2024

Conversation

paulushcgcj
Copy link
Collaborator

@paulushcgcj paulushcgcj commented Oct 7, 2024 •
edited by github-actions bot
Loading

Description

Updated predictive endpoint to be able to run both predictive and full search as both results are the same.

  • Updated endpoint to be just search (/api/search)
  • Updated the controller to be able to search for the latest
  • Updated query to include pagination
  • Added default page values for predictive
  • Changed tests

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update
  • Documentation update

How Has This Been Tested?

  • New integrated tests
  • Updated existing tests

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@paulushcgcj
feat(FSADT1-1528): added external pagination info for predictive
d575e17
@paulushcgcj
feat(FSADT1-1528): updated predictive endpoint to complex
be5b942 
- Updated endpoint to be just search
- Updated the controller to be able to search for latest
- Updated query to include pagination
- Added default page values for predictive
- Changed tests
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024 •
edited
Loading

Current changelog

Bug Fixes

  • FSADT1-1528: fixing search (69682b3)

Features

  • FSADT1-1528: added external pagination info for predictive (d575e17)
  • FSADT1-1528: updated predictive endpoint to complex (be5b942)

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@mamartinezmejia mamartinezmejia enabled auto-merge (squash) October 8, 2024 16:59
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@mamartinezmejia mamartinezmejia merged commit 550c941 into main Oct 8, 2024
24 checks passed
@mamartinezmejia mamartinezmejia deleted the feat/FSADT1-1528 branch October 8, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamartinezmejia mamartinezmejia mamartinezmejia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulushcgcj @mamartinezmejia