Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FSADT1-1525): Add FAM role CLIENT_SUSPEND #1247

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

mamartinezmejia
Copy link
Collaborator

@mamartinezmejia mamartinezmejia commented Oct 17, 2024


Thanks for the PR!

Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Copy link

Current changelog

Features

  • FSADT1-1525: Add FAM role CLIENT_SUSPEND (b6e6333)

Copy link

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

Copy link
Collaborator

@fterra-encora fterra-encora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving it.
But do we need to add that role as authorized on other endpoints?
Because so far it's only added to the "/api/clients/search/**".

@mamartinezmejia
Copy link
Collaborator Author

I'm approving it. But do we need to add that role as authorized on other endpoints? Because so far it's only added to the "/api/clients/search/**".

Yes, it is for that endpoint only
https://apps.nrs.gov.bc.ca/int/confluence/display/FSADT1/Forest+Client+Management+FAM+roles

Copy link
Collaborator

@paulushcgcj paulushcgcj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done

@mamartinezmejia mamartinezmejia merged commit 7aa77de into main Oct 17, 2024
26 checks passed
@mamartinezmejia mamartinezmejia deleted the feat/FSADT1-1525 branch October 17, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants