Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SRS-541: Site Save: Implement on documents #107

Merged
merged 5 commits into from
Oct 18, 2024
Merged

Conversation

jaspalsingh-aot
Copy link
Contributor

@jaspalsingh-aot jaspalsingh-aot commented Oct 18, 2024

Description

This pull request introduces the following updates to the frontend functionality of the document tab:

  • Implemented features to upload, replace, and delete file details within the database.

Fixes # (issue)

  • Fixed frontend test cases for various components, including Associate, Dashboard, Notation, Disclosure, and Document.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@jaspalsingh-aot jaspalsingh-aot changed the title Feat/srs 541 SRS-541: Site Save: Implement on documents Oct 18, 2024
@jaspalsingh-aot jaspalsingh-aot changed the title SRS-541: Site Save: Implement on documents Feat: SRS-541: Site Save: Implement on documents Oct 18, 2024
@jaspalsingh-aot jaspalsingh-aot changed the title Feat: SRS-541: Site Save: Implement on documents feat: SRS-541: Site Save: Implement on documents Oct 18, 2024
Copy link
Contributor

@midhun-aot midhun-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@midhun-aot midhun-aot merged commit 7e670f9 into dev Oct 18, 2024
14 checks passed
@midhun-aot midhun-aot deleted the feat/srs-541 branch October 18, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants