Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cicd): Finally have test environment up, this PR now merges working functionality back into dev. #112

Merged
merged 6 commits into from
Oct 18, 2024

Conversation

acoard-aot
Copy link
Contributor

@acoard-aot acoard-aot commented Oct 18, 2024

Description

Iterated in this feature branch for a while to get things working and deployed in test. Now that everything is sorted, merging back into dev.

With this PR, once things are merged into dev it should handle deploying to test.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Note: Have re-enabled triggers here. If having any problem with triggers, just comment out line 34 of this commit, leaving it blank will re-deploy everything.
@mishraomp mishraomp merged commit ee71636 into dev Oct 18, 2024
14 checks passed
@mishraomp mishraomp deleted the fix/cicd-dev-triggers branch October 18, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants