Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRC-773, PRC-776: updates to application service #283

Merged
merged 1 commit into from
Oct 19, 2018
Merged

PRC-773, PRC-776: updates to application service #283

merged 1 commit into from
Oct 19, 2018

Conversation

severinbeauvais
Copy link
Contributor

@severinbeauvais severinbeauvais commented Oct 17, 2018

PRC-773: added missing things to get Application

  • overrode pagination when retrieving applications (max 1M results)
  • fixed getByTantalisID() to get extra app data
  • added missing comment count
  • added missing \n replacement for descriptions
  • added missing 7-digit CL code
  • updated headers to display modified CL code
  • misc cleanup

PRC-776: parameterized application 'get' functions + model cleanup

  • refactored code to use common function to retrieve extra app data
  • parameterized application 'get' functions to retrieve only required extra data
  • removed obsolete app caching
  • moved some property code to models
  • added 'user-friendly display' fields to app model for better typing
  • added missing document and features copy code to app model
  • a bit of cleanup

PRC-773: added missing things to Get Application

PRC-776: parameterized application 'get' functions + model cleanup
@severinbeauvais severinbeauvais changed the title PRC-776: NEEDS REBASE AFTER PRC-773 IS MERGED @severinbeauvais PRC-773, PRC-776: updates to application service Oct 18, 2018
@severinbeauvais severinbeauvais changed the title @severinbeauvais PRC-773, PRC-776: updates to application service PRC-773, PRC-776: updates to application service Oct 18, 2018
@marklise marklise merged commit 1ea21ab into bcgov:scale Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants