PRC-753: replaced file upload control with custom component + cleanup #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
severinbeauvais
commented
Oct 22, 2018
•
severinbeauvais
commented
- deleted obsolete Add Comment component
- updated custom File Upload component (from Public plus changes to look like original Admin control)
- moved stand-alone components to root + cleaned up modules
- updated add-edit page to use custom File Upload component + removed references to old file upload
- added null de-ref check to login
… Upload component (from Public plus changes to look like orig Admin component) + moved stand-alone components to root + cleaned up modules + updated add-edit page to use custom File Upload component + removed references to old file upload + null deref check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.