PRC-748: return PRC results even if no BCGW results #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
severinbeauvais
commented
Oct 23, 2018
•
severinbeauvais
commented
- added extra checks in case application is not found (eg, was deleted)
- simplified search page to only know about Application objects (logic moved to search service)
- added getApplicationsByCrownLandID() to api
- added getByCrownLandID() to application service
- added extra checks for null data
- added missing catch blocks for error handling
- updated search service to return PRC results even if BCGW is not responding or returns no results
- simplified search service to return array of Application
severinbeauvais
changed the title
severinbeauvais
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.