PRC-788: clean up api and services (see details) #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
severinbeauvais
commented
Oct 26, 2018
•
severinbeauvais
commented
- added missing new object mappings in services
- moved object mappings into their respective service
- renamed some functions for consistency
- replaced some _.each with .forEach
- removed remaining (obsolete) caching in services
- fixed some model constructors
- added missing isPublished code to models
- get documents for all comments (for easier merge with PR-536)
- refactored api.ts to use template literals and helper function for simpler code
- added missing / fixed incorrect typings
- reduced getAllApplications max records
- count only pending comments
- removed fields for add/save since API ignores them
- removed superfluous getNumComments flag
- removed broken change detection from search page
- added params to comment and decision services
- replaced forEach() with for() in models
…ect mappings into their respective service + replaced some _.each with .forEach + removed remaining caching in services + fixed some model constructors + added missing isPublished code to models + reduced getAllApplications max records + count only pending comments + get documents for all comments + removed fields for add/save since API ignores them + removed superfluous getNumComments flag + removed broken change detection from search page + added params to comment and decision services + replaced forEach() with for() in models only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.