Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRC-1028: prevent create/publish/edit/save when app is retired #343

Merged
merged 1 commit into from
Jan 30, 2019
Merged

PRC-1028: prevent create/publish/edit/save when app is retired #343

merged 1 commit into from
Jan 30, 2019

Conversation

severinbeauvais
Copy link
Contributor

  • also added tooltips
  • also changed some dynamic properties to actual properties

@NickPhura
Copy link
Contributor

Looks good.

Two questions:

  1. Is there a reason for the back and forth use/changes between bracket and dot notation? IE: x.['y'] vs x.y
  2. (subjective/minor) I feel like the '+ create' button is not greyed out enough. Either maybe the colour needs to be grey, or the button needs to be more faint? Not sure, but I didnt initially notice it was unclickable until I tried.

@severinbeauvais
PRC-1028: prevent create/publish/edit/save when app is retired
4ea332f 
- also added tooltips to buttons
- also changed some dynamic properties to actual properties
@NickPhura NickPhura merged commit 9ba4041 into bcgov:master Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickPhura NickPhura NickPhura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@severinbeauvais @NickPhura