Skip to content

Commit

Permalink
NOBUG: fix test runner failures
Browse files Browse the repository at this point in the history
Set node 14 via setup-node action, and update test packages.
  • Loading branch information
cole committed Dec 7, 2021
1 parent 44f25d9 commit dfedf4b
Show file tree
Hide file tree
Showing 5 changed files with 503 additions and 529 deletions.
37 changes: 17 additions & 20 deletions .github/workflows/deploy-dev.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,15 @@ jobs:
environment: dev
strategy:
matrix:
node-version: [14.x]
node: ['14']
steps:
- uses: actions/checkout@v2
- uses: actions/cache@v2
- uses: actions/setup-node@v2
with:
path: '**/node_modules'
key: ${{ runner.os }}-modules-${{ hashFiles('**/yarn.lock') }}

node-version: ${{ matrix.node }}
cache: 'yarn'
- name: Install dependencies
if: steps.yarn-cache.outputs.cache-hit != 'true'
run: yarn install --frozen-lockfile

- run: yarn lint
Expand All @@ -41,16 +40,15 @@ jobs:
environment: dev
strategy:
matrix:
node-version: [14.x]
node: ['14']
steps:
- uses: actions/checkout@v2
- uses: actions/cache@v2
- uses: actions/setup-node@v2
with:
path: '**/node_modules'
key: ${{ runner.os }}-modules-${{ hashFiles('**/yarn.lock') }}

node-version: ${{ matrix.node }}
cache: 'yarn'
- name: Install dependencies
if: steps.yarn-cache.outputs.cache-hit != 'true'
run: yarn install --frozen-lockfile

- run: yarn test-ci
Expand All @@ -65,16 +63,15 @@ jobs:
environment: dev
strategy:
matrix:
node-version: [14.x]
node: ['14']
steps:
- uses: actions/checkout@v2
- uses: actions/cache@v2
- uses: actions/setup-node@v2
with:
path: '**/node_modules'
key: ${{ runner.os }}-modules-${{ hashFiles('**/yarn.lock') }}

node-version: ${{ matrix.node }}
cache: 'yarn'
- name: Install dependencies
if: steps.yarn-cache.outputs.cache-hit != 'true'
run: yarn install --frozen-lockfile

- name: Setting configEndpoint to true
Expand Down Expand Up @@ -115,7 +112,7 @@ jobs:
environment: dev
strategy:
matrix:
node-version: [14.x]
node: ['14']
steps:
- name: Check out the repo
uses: actions/checkout@v2
Expand Down Expand Up @@ -191,7 +188,7 @@ jobs:
environment: dev
strategy:
matrix:
node-version: [14.x]
node: ['14']
steps:
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v1
Expand Down
24 changes: 11 additions & 13 deletions .github/workflows/on-pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,15 @@ jobs:
environment: dev
strategy:
matrix:
node-version: [14.x]
node: ['14']
steps:
- uses: actions/checkout@v2
- uses: actions/cache@v2
- uses: actions/setup-node@v2
with:
path: '**/node_modules'
key: ${{ runner.os }}-modules-${{ hashFiles('**/yarn.lock') }}

node-version: ${{ matrix.node }}
cache: 'yarn'
- name: Install dependencies
if: steps.yarn-cache.outputs.cache-hit != 'true'
run: yarn install --frozen-lockfile

- run: yarn lint
Expand All @@ -32,19 +31,18 @@ jobs:
environment: dev
strategy:
matrix:
node-version: [14.x]
node: ['14']
steps:
- uses: actions/checkout@v2
- uses: actions/cache@v2
- uses: actions/setup-node@v2
with:
path: '**/node_modules'
key: ${{ runner.os }}-modules-${{ hashFiles('**/yarn.lock') }}

node-version: ${{ matrix.node }}
cache: 'yarn'
- name: Install dependencies
if: steps.yarn-cache.outputs.cache-hit != 'true'
run: yarn install --frozen-lockfile

- run: yarn test-ci
- name: Cancelling workflow due to error
if: ${{ failure() }}
uses: andymckay/cancel-action@0.2
uses: andymckay/cancel-action@0.2
2 changes: 1 addition & 1 deletion .tool-versions
Original file line number Diff line number Diff line change
@@ -1 +1 @@
nodejs 10.19.0
nodejs 14.18.2
16 changes: 8 additions & 8 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,20 +68,20 @@
"@angular/compiler": "~8.2.14",
"@angular/compiler-cli": "~8.2.14",
"@types/arcgis-js-api": "4.6.0",
"@types/jasmine": "2.8.6",
"@types/jasmine": "3.10.2",
"@types/lodash": "4.14.106",
"@types/node": "~10.17.17",
"jasmine-core": "~3.5.0",
"jasmine-spec-reporter": "~4.2.1",
"karma": "~4.4.1",
"jasmine-core": "~3.10.1",
"jasmine-spec-reporter": "~7.0.0",
"karma": "~6.3.9",
"karma-chrome-launcher": "~3.1.0",
"karma-cli": "~2.0.0",
"karma-coverage": "~2.0.3",
"karma-jasmine": "~3.1.1",
"karma-jasmine-html-reporter": "~1.5.2",
"karma-coverage": "~2.1.0",
"karma-jasmine": "~4.0.1",
"karma-jasmine-html-reporter": "~1.7.0",
"pre-push": "~0.1.1",
"protractor": "~5.4.3",
"puppeteer": "~2.1.1",
"puppeteer": "~12.0.1",
"tree-kill": "~1.2.2",
"ts-node": "7.0.1",
"typescript": "~3.4.5"
Expand Down
Loading

0 comments on commit dfedf4b

Please sign in to comment.