Skip to content

Commit

Permalink
Table A11Y Updates (#2025)
Browse files Browse the repository at this point in the history
  • Loading branch information
cameron-eyds authored Sep 19, 2024
1 parent 7e83fa8 commit 372f510
Show file tree
Hide file tree
Showing 13 changed files with 76 additions and 28 deletions.
4 changes: 2 additions & 2 deletions ppr-ui/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ppr-ui/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ppr-ui",
"version": "3.2.56",
"version": "3.2.57",
"private": true,
"appName": "Assets UI",
"sbcName": "SBC Common Components",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<v-container
v-if="isSummary"
class="pb-0 px-0"
role="region"
>
<v-row
v-if="vehicleCollateral && vehicleCollateral.length > 0"
Expand Down
10 changes: 8 additions & 2 deletions ppr-ui/src/components/common/AccountInfo.vue
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
<template>
<div id="account-info">
<div
id="account-info"
role="region"
>
<h2 class="header mb-5">
{{ title }}
<v-tooltip
Expand Down Expand Up @@ -52,7 +55,10 @@
</thead>
<tbody>
<tr class="table-info">
<td class="account-name pl-8 py-6">
<td
class="account-name pl-8 py-6"
:aria-label="accountInfo.isBusinessAccount ? 'Business' : 'Person' + accountInfo.name"
>
<v-icon class="mt-n2">
{{ accountInfo.isBusinessAccount ? 'mdi-domain' : 'mdi-account' }}
</v-icon>
Expand Down
1 change: 1 addition & 0 deletions ppr-ui/src/components/common/CertifyInformation.vue
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<v-container
id="certify-summary"
class="px-0"
role="region"
>
<h2>
{{ `${sectionNumber ? sectionNumber + '.' : ''} Authorization` }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1413,12 +1413,6 @@ export default defineComponent({
td:first-child {
padding-left: 0 !important;
}
.owner-info {
align-items: baseline;
min-width: 50rem;
display: flex;
}
}
tbody > tr.v-row-group__header {
Expand Down
13 changes: 11 additions & 2 deletions ppr-ui/src/components/parties/debtor/Debtors.vue
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
id="debtors-component"
fluid
class="pa-0 noGutters"
role="region"
>
<v-row noGutters>
<v-col cols="auto">
Expand Down Expand Up @@ -82,6 +83,7 @@
v-for="header in headers"
:key="header.value"
:class="header.class"
:aria-hidden="!header.text"
>
{{ header.text }}
</th>
Expand Down Expand Up @@ -122,9 +124,13 @@
class="list-item__title title-text generic-label"
style="padding-left:30px"
>
<v-row noGutters>
<v-row
noGutters
:aria-label="`${isBusiness(item) ? 'Business' : 'Person'} ${getName(item)}`"
>
<v-col
cols="auto"
aria-hidden="true"
:class="{ 'disabled-text': item.action === ActionTypes.REMOVED}"
>
<div class="icon-div mt-n1 pr-2">
Expand All @@ -136,7 +142,10 @@
</v-icon>
</div>
</v-col>
<v-col cols="9">
<v-col
cols="9"
aria-hidden="true"
>
<span :class="{ 'disabled-text': item.action === ActionTypes.REMOVED}">
{{ getName(item) }}
</span>
Expand Down
20 changes: 16 additions & 4 deletions ppr-ui/src/components/parties/party/RegisteringParty.vue
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
<template>
<v-container class="pa-0 flat">
<v-container
class="pa-0 flat"
role="region"
>
<v-container class="pa-0">
<v-row
noGutters
Expand Down Expand Up @@ -31,8 +34,14 @@
<td
class="generic-label"
>
<v-row noGutters>
<v-col cols="auto">
<v-row
noGutters
:aria-label="`${isBusiness(item) ? 'Business' : 'Person'} ${getName(item)}`"
>
<v-col
cols="auto"
aria-hidden="true"
>
<div class="icon-div mt-n1 pr-2">
<v-icon v-if="isBusiness(item)">
mdi-domain
Expand All @@ -42,7 +51,10 @@
</v-icon>
</div>
</v-col>
<v-col cols="9">
<v-col
cols="9"
aria-hidden="true"
>
<div>
{{ getName(item) }}
</div>
Expand Down
15 changes: 10 additions & 5 deletions ppr-ui/src/components/parties/party/SecuredParties.vue
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
id="secured-parties-component"
fluid
class="pa-0 noGutters"
role="region"
>
<ChangeSecuredPartyDialog
attach="#app"
Expand Down Expand Up @@ -187,10 +188,11 @@
</template>
<!-- Table Cells -->
<template v-else>
<td
class="list-item__title"
>
<v-row noGutters>
<td class="list-item__title">
<v-row
noGutters
:aria-label="`${isBusiness(item) ? 'Business' : 'Person'} ${getName(item)}`"
>
<v-col
cols="auto"
:class="{ 'disabled-text': item.action === ActionTypes.REMOVED}"
Expand All @@ -204,7 +206,10 @@
</v-icon>
</div>
</v-col>
<v-col cols="9">
<v-col
cols="9"
aria-hidden="true"
>
<div :class="{ 'disabled-text': item.action === ActionTypes.REMOVED}">
<span class="font-weight-bold">{{ getName(item) }}</span>
</div>
Expand Down
11 changes: 9 additions & 2 deletions ppr-ui/src/components/parties/summaries/BasePartySummary.vue
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<v-card
class="pa-0 mx-0"
flat
role="region"
>
<v-row
v-if="options.header"
Expand Down Expand Up @@ -52,7 +53,10 @@
<td
class="list-item__title"
>
<v-row noGutters>
<v-row
noGutters
:aria-label="`${isBusiness(item) ? 'Business' : 'Person'} ${getName(item)}`"
>
<v-col cols="auto">
<div class="icon-div mt-n1 pr-2">
<v-icon v-if="isBusiness(item)">
Expand All @@ -63,7 +67,10 @@
</v-icon>
</div>
</v-col>
<v-col cols="9">
<v-col
cols="9"
aria-hidden="true"
>
<div :class="{ 'disabled-text': item?.action === ActionTypes.REMOVED}">
<span class="font-weight-bold">{{ getName(item) }}</span>
</div>
Expand Down
2 changes: 2 additions & 0 deletions ppr-ui/src/components/tables/mhr/HomeSectionsTable.vue
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
flat
rounded
class="mt-2"
role="region"
>
<v-table
id="mh-home-sections-table"
Expand All @@ -18,6 +19,7 @@
v-for="header in headers"
:key="header.value"
:class="[header.class, (isReviewMode && header == headers[0]) ? 'pl-0' : '']"
:aria-hidden="!header.text"
>
{{ header.text }}
</th>
Expand Down
5 changes: 4 additions & 1 deletion ppr-ui/src/components/tables/ppr/SearchedResults.vue
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
<template>
<v-container class="pa-0 bg-white pb-0">
<v-container
class="pa-0 bg-white pb-0"
role="region"
>
<!-- Results Header -->
<v-row
v-if="searched"
Expand Down
14 changes: 11 additions & 3 deletions ppr-ui/src/components/unitNotes/UnitNoteContentInfo.vue
Original file line number Diff line number Diff line change
Expand Up @@ -188,13 +188,21 @@
<!-- Table Body -->
<tbody>
<tr>
<td class="pl-0">
<div class="mr-2">
<td class="pl-0 dp__flex_display">
<div
class="mr-2"
:aria-label="
`${note.businessName ? 'Business' : 'Person'} ${getNoticePartyName(note.givingNoticeParty)}`
"
>
<v-icon class="notice-party-icon colour-dk-text mt-n2">
{{ getNoticePartyIcon(note.givingNoticeParty) }}
</v-icon>
</div>
<span class="notice-party-name generic-label fs-14">
<span
class="notice-party-name generic-label fs-14"
aria-hidden="true"
>
{{ getNoticePartyName(note.givingNoticeParty) }}
</span>
</td>
Expand Down

0 comments on commit 372f510

Please sign in to comment.