Effective Date and Time for Unit Notes #1415
Conversation
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-assets-dev--pr-1415-gura6rd7.web.app |
| /** | ||
| * Creates and mounts a component, so that it can be tested. | ||
| * | ||
| * @returns a Wrapper<Any> object with the given parameters. | ||
| */ | ||
| function createComponent (propsData: any): Wrapper<any> { | ||
| const localVue = createLocalVue() | ||
| localVue.use(Vuetify) | ||
|
|
||
| return mount((EffectiveDateTime as any), { | ||
| localVue, | ||
| propsData, | ||
| vuetify | ||
| }) | ||
| } |
There was a problem hiding this comment.
I believe there is a common function from the test utils folder we can use.
Trying to get away from having this function in every test file.
| const expiryDateTime = new Date(new Date(val).getTime() + 90 * 24 * 60 * 60 * 1000).toISOString() | ||
| setMhrUnitNote({ key: 'expiryDateTime', value: expiryDateTime }) |
There was a problem hiding this comment.
The UI creates/sets the expiry date? I assumed it just passed the effectiveDateTime to the api 🤔
There was a problem hiding this comment.
CAUC can submit an expiry date, CAUE must submit an expiry date.
There was a problem hiding this comment.
Is there implications if the user modifies there local system time here?
There was a problem hiding this comment.
@cameron-eyds I thought so too, but then I looked at API spec again, and there was the expiry date that we need to submit, so I added it here. There may be implications if local time on machine changes.
Maybe we can pass a flag (and not the date/time string) that the effective date is immediate? Then based on that server generates effective and exp date? For past date, we can just pass a date/string in past. The only problem I see is that the user will not see the (server time) summary note about the Notice at the bottom of the component.
| @@ -0,0 +1,236 @@ | |||
| <template> | |||
| <div id="contact-info-container"> | |||
There was a problem hiding this comment.
copy pasta carry over i think
| expect(EffectiveDateTimeComponent.find(getTestId('time-picker-fields')).exists()).toBeTruthy() | ||
| expect(EffectiveDateTimeComponent.find(getTestId('footnote-label')).exists()).toBeFalsy() | ||
| }) | ||
| }) |
There was a problem hiding this comment.
Is it possible to add another test or two, to prove the time selected and/or format?
dimak1
force-pushed
the
feat/unit-note-effective-date
branch
from
012da73
to
e1a5465
Compare
Codecov Report
@@ Coverage Diff @@
## main #1415 +/- ##
==========================================
+ Coverage 72.35% 77.24% +4.89%
==========================================
Files 307 332 +25
Lines 12767 6123 -6644
Branches 2630 963 -1667
==========================================
- Hits 9237 4730 -4507
+ Misses 3518 1361 -2157
- Partials 12 32 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-assets-dev--pr-1415-gura6rd7.web.app |
|
Pending UXA feedback. Will merge after. |
dimak1
force-pushed
the
feat/unit-note-effective-date
branch
from
e1a5465
to
8a6ed20
Compare
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-assets-dev--pr-1415-gura6rd7.web.app |
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-assets-dev--pr-1415-gura6rd7.web.app |
|
Pending another round of UXA. |
Issue #:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).